fix: Remove await from listener.forward() on NgrokProxy class#18
Merged
Conversation
await from listener.forward() on NgrokProxy classawait from listener.forward() on NgrokProxy class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent subsequent processing from stopping, I removed
awaitfrom the call tolistener.forward()in the NgrokProxy class.Reason
listener.forward()returns a Promise, but this Promise does not seem to resolve until the forwarding task is complete. Therefore, usingawaitcauses subsequent processing to stop, and the CLI no longer works properly.In fact, when the following command was executed in the current main branch, nothing was output to the terminal:
Internally, the endpoint was created on Ngrok, but the endpoint URL on the LINE Developers Console was not updated.
In the official documentation sample,
listener.forward()is also called withoutawait:https://github.com/ngrok/ngrok-javascript?tab=readme-ov-file#builders
After removing
await, ngrok processed normally, and the endpoint URL on the LINE Developers Console was also updated.