Skip to content

TPT-2509: Use official golangci-lint GitHub Action - #158

Merged
zliang-akamai merged 1 commit into
linode:mainfrom
zliang-akamai:TPT-2509-use-golangci-lint-action
Sep 9, 2026
Merged

zliang-akamai merged 1 commit into
linode:mainfrom
zliang-akamai:TPT-2509-use-golangci-lint-action

Conversation

@zliang-akamai

Copy link
Copy Markdown
Member

📝 Description

Switch CI linting from make lint (Docker golangci/golangci-lint) to the official golangci/golangci-lint-action. Keep local make lint on the host golangci-lint CLI and drop the Docker/SKIP_DOCKER Makefile path.

✔️ How to Test

make lint

Confirm the CI workflow golangci-lint job succeeds on this PR.

@zliang-akamai zliang-akamai added the repo-ci-improvement for improvements in the repository or CI workflow in the changelog. label Aug 29, 2026
@zliang-akamai
zliang-akamai requested review from a team as code owners August 29, 2026 03:45
@zliang-akamai
zliang-akamai requested review from lgarber-akamai and psnoch-akamai and a lite review from Copilot and removed request for a team August 29, 2026 03:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s linting workflow by moving CI lint execution off the Makefile/Docker-based make lint path and onto the official golangci/golangci-lint-action, while keeping local linting as a direct golangci-lint CLI invocation.

Changes:

  • Remove the Docker/SKIP_DOCKER branch from make lint so linting always uses the local golangci-lint binary.
  • Switch the CI workflow lint step to golangci/golangci-lint-action.
  • Update agent guidance to reflect the new local lint expectation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Makefile Simplifies lint to always run local golangci-lint (removes Docker/SKIP_DOCKER path).
AGENTS.md Updates lint command documentation to match the Makefile/CI changes.
.github/workflows/ci.yml Replaces make lint with the official golangci-lint GitHub Action step in CI.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.yml
@zliang-akamai
zliang-akamai merged commit ef34e64 into linode:main Sep 9, 2026
4 checks passed
@zliang-akamai
zliang-akamai deleted the TPT-2509-use-golangci-lint-action branch September 9, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

repo-ci-improvement for improvements in the repository or CI workflow in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants