TPT-4577: Merge RDMA VPCs to Main - #1016
Open
yec-akamai wants to merge 4 commits into
Open
Conversation
yec-akamai
requested review from
psnoch-akamai and
zliang-akamai
and removed request for
a team
July 28, 2026 19:41
Contributor
There was a problem hiding this comment.
Pull request overview
This PR brings RDMA-capable VPC support (and corresponding tests/fixtures) from the proj/rdma-interfaces branch into the main linodego client, exposing a vpc_type field and adding coverage for RDMA create/get/list behaviors.
Changes:
- Add
VPCTypeenum +vpc_typefields to VPC and VPC subnet models, and plumb through VPC create options. - Add unit tests + fixtures for RDMA VPC create/get and subnet unmarshalling.
- Update integration tests and fixtures to cover RDMA VPC/subnet flows and refreshed API validation responses; add new region capability constant for GPUDirect RDMA.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vpc.go | Introduces VPCType and adds vpc_type to VPC + create options. |
| vpc_subnet.go | Adds vpc_type to VPCSubnet for RDMA/regular differentiation. |
| regions.go | Adds CapabilityGPUDirectRDMA region capability constant. |
| test/unit/rdma_vpc_test.go | Adds unit coverage for RDMA VPC create/get and subnet vpc_type unmarshal. |
| test/unit/fixtures/vpc_rdma_get.json | New unit fixture for RDMA VPC GET response. |
| test/unit/fixtures/vpc_rdma_create.json | New unit fixture for RDMA VPC create response. |
| test/integration/vpc_test.go | Extends VPC integration tests to validate vpc_type and adds RDMA-specific scenarios. |
| test/integration/vpc_subnet_test.go | Adds assertions/coverage for subnet vpc_type, including RDMA subnet flow. |
| test/integration/lke_clusters_test.go | Updates VPC helper callsites for changed createVPC signature. |
| test/integration/fixtures/TestVPC_WithRDMAType.yaml | New integration cassette covering RDMA VPC create/get/list + cleanup. |
| test/integration/fixtures/TestVPC_WithRDMATypeAndIPv6_Fail.yaml | New cassette covering expected API failure when RDMA VPC includes IPv6 ranges. |
| test/integration/fixtures/TestVPC_Subnet_WithRDMAType.yaml | New cassette covering RDMA VPC subnet create/get/list + cleanup. |
| test/integration/fixtures/TestVPC_Create_Invalid.yaml | Updates invalid-create cassette to match refreshed prod validation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mawilk90
reviewed
Jul 29, 2026
Contributor
|
Referring to our Slack discussion, is it fine with RDMA test fixtures to be included in this PR? |
Contributor
Author
The RDMA VPCs are already in prod, so it's fine. I don't include any RDMA interfaces in the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Part of the RDMA interfaces project (vpc and subnet) is now available in prod. We need to separate them from the proj branch. I check out and cheery pick the VPC related implementations and test from the proj/rdma-interfaces branch. Only the fixtures are regenerated from the test against prod.
✔️ How to Test