Closed
Fix pyrefly type errors in __init__.py and ltx_chan.py#104
__init__.py and ltx_chan.py#104Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build (3.9)
Fix pyrefly type errors in Jul 15, 2026
__init__.py and ltx_chan.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build (3.9)CI job was failing becausepyrefly checkreported 2 type errors that weren't being properly suppressed.Changes
libkirk/__init__.py: The pyrefly suppression comment for the deprecatedasyncio.gather(..., loop=loop, ...)call used the wrong error code (bad-argument-type). Pyrefly reports this asno-matching-overloadsince its stubs omit the removedloopparameter entirely. Updated the ignore directive accordingly:libkirk/channels/ltx_chan.py: Instop(), the untypedrequests = []list was inferred aslist[Requests.kill]— which, due to list invariance, is not assignable to thelist[Request]parameter of_send_requests(). Added an explicit annotation to declare the intended type upfront: