Skip to content

Fix pyrefly type errors in __init__.py and ltx_chan.py - #104

Closed
acerv with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-build-3-9-failure
Closed

Fix pyrefly type errors in __init__.py and ltx_chan.py#104
acerv with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-build-3-9-failure

Conversation

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown

The build (3.9) CI job was failing because pyrefly check reported 2 type errors that weren't being properly suppressed.

Changes

  • libkirk/__init__.py: The pyrefly suppression comment for the deprecated asyncio.gather(..., loop=loop, ...) call used the wrong error code (bad-argument-type). Pyrefly reports this as no-matching-overload since its stubs omit the removed loop parameter entirely. Updated the ignore directive accordingly:

    # pyrefly: ignore[no-matching-overload]
    asyncio.gather(*tasks, loop=loop, return_exceptions=True)
  • libkirk/channels/ltx_chan.py: In stop(), the untyped requests = [] list was inferred as list[Requests.kill] — which, due to list invariance, is not assignable to the list[Request] parameter of _send_requests(). Added an explicit annotation to declare the intended type upfront:

    requests: List[Request] = []

Copilot AI changed the title [WIP] Fix failing GitHub Actions job build (3.9) Fix pyrefly type errors in __init__.py and ltx_chan.py Jul 15, 2026
Copilot finished work on behalf of acerv July 15, 2026 11:56
Copilot AI requested a review from acerv July 15, 2026 11:56
@acerv acerv closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants