Skip to content

Wip xio#1

Open
mattbenjamin wants to merge 6008 commits into
masterfrom
wip-xio
Open

Wip xio#1
mattbenjamin wants to merge 6008 commits into
masterfrom
wip-xio

Conversation

@mattbenjamin

@mattbenjamin mattbenjamin commented Dec 19, 2014

Copy link
Copy Markdown

This is a pre-pull request, designed to give folks a chance to review the current XioMessenger integration for Hammer.

@mattbenjamin

mattbenjamin commented Dec 23, 2014

Copy link
Copy Markdown
Author

This branch has a known bug (being fixed), but it attempts rebasing per feedback.

@mattbenjamin mattbenjamin force-pushed the wip-xio branch 3 times, most recently from 7365705 to 487789d Compare January 6, 2015 23:31
mattbenjamin pushed a commit that referenced this pull request Jan 14, 2015
@dalgaaf
test/librados/aio.cc: release completion before exit
1a00fb7 
CID 1242020 (#1 of 1): Resource leak (RESOURCE_LEAK)
 leaked_storage: Variable my_completion going out of scope
 leaks the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Jan 14, 2015
@dalgaaf
librados/librados.cc: fix UNINIT issue
8511b55 
Fix for issues introduced with cba4ed4:

CID 1256099 (#1 of 1): Uninitialized pointer read (UNINIT)
 uninit_use: Using uninitialized value this->impl.

CID 1256100 (#1 of 1): Uninitialized pointer read (UNINIT)
 uninit_use: Using uninitialized value this->impl.

Don't delete a pointer in the constructor if the pointer
isn't initialized before.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Jan 14, 2015
@dalgaaf
mds/MDLog.cc: fix uninitialized pointer read
c27e0fe 
Fix for Coverity issue:

CID 1238902 (#1 of 1): Uninitialized pointer read (UNINIT)
 uninit_use: Using uninitialized value this->mdlog.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Jan 14, 2015
@dalgaaf
src/common/obj_bencher: fix some UNINIT issues
aacdaae 
Make sure concurrentios is always >= 0 to fix these coverity
issues and to prevent bad_alloc/negative array sizes:

CID 1128404 (#1 of 1): Uninitialized scalar variable (UNINIT)
 uninit_use: Using uninitialized value index[slot].

CID 1128405 (#1 of 1): Uninitialized pointer read (UNINIT)
 uninit_use: Using uninitialized value contents[slot].

CID 1219644 (#1 of 1): Uninitialized pointer read (UNINIT)
 uninit_use: Using uninitialized value contents[slot].

CID 1219645 (#1 of 1): Uninitialized pointer read (UNINIT)
 uninit_use: Using uninitialized value contents[slot].

CID 1219646 (#1 of 1): Uninitialized scalar variable (UNINIT)
 uninit_use: Using uninitialized value index[slot].

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Jan 14, 2015
@dalgaaf
crush/crush.c: prevent DIVIDE_BY_ZERO
fd4ac46 
Fix for:

CID 1219471 (#1 of 1): Division or modulo by zero (DIVIDE_BY_ZERO)
 divide_by_zero: In function call crush_make_uniform_bucket,
 division by expression item_weight which may be zero has undefined
 behavior.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Jan 14, 2015
@dalgaaf
osd/ClassHandler.cc: move stat into error handling
b99508b 
There is no security advantage to check if the class file
exists before opening it but the file could be removed or
exchanged between the stat and open. Instead directly open
it and fail. Check if the file was missing afterwards
for debug messages and error codes.

Make sure cls->status is set if the class open call fails.

To solve Coverity issue:

CID 743419 (#1 of 1): Time of check time of use (TOCTOU)
 fs_check_call: Calling function stat to perform check on fname.

743419 Time of check time of use
 An attacker could change the filename's file association or
 other attributes between the check and use.

 In ClassHandler::_load_class(ClassHandler::ClassData *): A check
 occurs on a file's attributes before the file is used in a
 privileged operation, but things may have changed (CWE-367)

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Feb 28, 2015
@dalgaaf
libradosstriper/striping.cc: fix resource leak
b7ea692 
Fix for:

CID 1221525 (#1 of 1): Resource leak (RESOURCE_LEAK)
 leaked_storage: Failing to save or free storage allocated
 by this->getObjName(soid, 0UL) leaks it.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cbodley pushed a commit that referenced this pull request May 22, 2015
@dalgaaf
sync_filesystem.h: fix unreachable code
9921836 
Fix for:

CID 1264460 (#1 of 1): Structurally dead code (UNREACHABLE)
unreachable: This code cannot be reached: sync();

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cbodley pushed a commit that referenced this pull request May 22, 2015
@dalgaaf
test_librbd.cc: fix USE_AFTER_FREE
d4b8d90 
Fix for:
CID 1251462 (#1 of 1): Use after free (USE_AFTER_FREE)
1. alias: Assigning: cur_name = names. Now both point to the same storage.
3. freed_arg: free frees names.
6. pass_freed_arg: Passing freed pointer cur_name as an argument to printf.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cbodley pushed a commit that referenced this pull request May 22, 2015
@dalgaaf
osdc/Striper.cc: fix OVERFLOW_BEFORE_WIDEN
3703940 
Fix for:
CID 1247719 (#1 of 1): Unintentional integer overflow
(OVERFLOW_BEFORE_WIDEN)
 overflow_before_widen: Potentially overflowing expression
 stripe_count * object_size with type unsigned int (32 bits,
 unsigned) is evaluated using 32-bit arithmetic before being
 used in a context which expects an expression of type
 uint64_t (64 bits, unsigned).

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cbodley pushed a commit that referenced this pull request May 22, 2015
@dalgaaf
osdc/Striper.cc: fix another OVERFLOW_BEFORE_WIDEN
d871889 
Fix for:

CID 1247720 (#1 of 1): Unintentional integer overflow
(OVERFLOW_BEFORE_WIDEN)
 overflow_before_widen: Potentially overflowing expression
 stripe_count * stripe_unit with type unsigned int (32 bits,
 unsigned) is evaluated using 32-bit arithmetic before being
 used in a context which expects an expression of type
 uint64_t (64 bits, unsigned).

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cbodley pushed a commit that referenced this pull request May 22, 2015
@dalgaaf
cls/rgw/cls_rgw_types.cc: fix RESOURCE_LEAK
b4cfe73 
Call push_back() for the generated entry object.

Fix for:

CID 1274297 (#1 of 1): Resource leak (RESOURCE_LEAK)
 3. leaked_storage: Variable entry going out of scope leaks
 the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cbodley pushed a commit that referenced this pull request May 22, 2015
@dalgaaf
test_async_driver.cc: fix NEGATIVE_RETURNS
e221463 
Fix for:

CID 1254374 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
1. negative_return_fn: Function socket(2, SOCK_STREAM, 0) returns a
   negative number.
2. var_assign: Assigning: signed variable connect_sd = socket.
3. negative_returns: connect_sd is passed to a parameter that cannot
   be negative.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cbodley pushed a commit that referenced this pull request May 22, 2015
@dalgaaf
blkdev.cc: fix STRING_OVERFLOW
9a3a8a0 
Fix for:

CID 1258439 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)
 2. fixed_size_dest: You might overrun the 4096 byte fixed-size
    string devname by copying dev + 5 without checking the length.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cbodley pushed a commit that referenced this pull request May 22, 2015
@dalgaaf
utime.h: fix OVERFLOW_BEFORE_WIDEN
a894223 
CID 1274295 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
 overflow_before_widen: Potentially overflowing expression
 usec * 1000 with type int (32 bits, signed) is evaluated using
 32-bit arithmetic before being used in a context which expects
 an expression of type uint64_t (64 bits, unsigned).

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cbodley pushed a commit that referenced this pull request May 22, 2015
@dalgaaf
psim.cc: change initialzation of VLAs
655c12a 
Use memset to fill integer VLAs.

Fix for:

CID 1219649 (#1 of 1): Uninitialized scalar variable (UNINIT)
 uninit_use: Using uninitialized value primary_count[primary]

CID 1219648 (#1 of 1): Uninitialized scalar variable (UNINIT)
 uninit_use: Using uninitialized value first_count[osds[0UL]]

CID 1219647 (#1 of 1): Uninitialized scalar variable (UNINIT)
 uninit_use: Using uninitialized value count[osds[i]]

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
cbodley pushed a commit that referenced this pull request May 22, 2015
@dalgaaf
test_async_driver.cc: fix UNINIT
c77ee13 
Fix for:

CID 1254380 (#1 of 1): Uninitialized scalar variable (UNINIT)
 uninit_use_in_call: Using uninitialized value sa. Field
 sa.sin_zero is uninitialized when calling connect

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
John Spray and others added 7 commits July 28, 2015 09:05
mds: fix standby handling in map
37370c7 
I broke this by taking the state from
the old mdsmap instead of the new one.

Signed-off-by: John Spray <john.spray@redhat.com>
mds: reinstate conditional destruction
61643c1 
Still got xlist not empty asserts on deletion of MDSRank,
so reinstate the condition that we only delete on
is_stopped().

Additionally, allow deletion in the case that we never had
a rank to begin with.

Signed-off-by: John Spray <john.spray@redhat.com>
@yuyuyu101
Merge pull request ceph#5349 from yuyuyu101/wip-async-fix-21
ef824a3 
AsyncConnection: Exit process loop if entering fault
@tchaikov
osd/ReplicatedPG: claim the read buffer instead of copying it
91ecba1 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Merge pull request ceph#5254 from vuhuong/wip-xio
11e313e 
@vuhuong sorry for the latency, could you please rebase & repush , to poke the built bot again?

once the build completes, will get it merged.

thanks,
@xdonghai
modified librados-intro.rst
d8395cf 
Signed-off-by: x11507 <xu.donghai@h3c.com>
@liewegas
Merge pull request ceph#5116 from yuyuyu101/wip-compressor
14542e7 
Wip compressor

Reviewed-by: Sage Weil <sage@redhat.com>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
messages/MOSDRepOp.h: init some vars of MOSDRepOp in ctor
fd82535 
Fix for:

CID 1262114 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
 uninit_member: Non-static class member map_epoch is not initialized
  in this constructor nor in any functions that it calls.
 uninit_member: Non-static class member acks_wanted is not initialized
  in this constructor nor in any functions that it calls.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
messages/MOSDRepOpReply.h: init some vars of MOSDRepOpReply in ctor
5b8ae62 
Fix for:

CID 1262115 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
 uninit_member: Non-static class member map_epoch is not initialized
  in this constructor nor in any functions that it calls.
 uninit_member: Non-static class member ack_type is not initialized
  in this constructor nor in any functions that it calls.
 uninit_member: Non-static class member result is not initialized
  in this constructor nor in any functions that it calls.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
rbd.cc: fix swapped arguments in do_lock_remove() call
b936da1 
Fix for:

CID 1297875 (#1 of 1): Arguments in wrong order (SWAPPED_ARGUMENTS)
 swapped_arguments: The positions of arguments in the call to
  do_lock_remove do not match the ordering of the parameters:
 lock_cookie is passed to client
 lock_client is passed to cookie

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
mds/MDSMap.cc: fix swapped arguments in CompatSet() ctor call
4c99000 
Fix for:

CID 1297874 (#1 of 1): Arguments in wrong order (SWAPPED_ARGUMENTS)
 swapped_arguments: The positions of arguments in the constructor
  for CompatSet do not match the ordering of the parameters:
 feature_incompat_base is passed to _ro_compat
 feature_ro_compat_base is passed to _incompat

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
rados/rados.cc: init non-static members in default ctor
239d229 
Fix for:

CID 717354 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
 uninit_member: Non-static class member id is not initialized in
  this constructor nor in any functions that it calls.
 uninit_member: Non-static class member type is not initialized in
  this constructor nor in any functions that it calls.
 uninit_member: Non-static class member off is not initialized in
  this constructor nor in any functions that it calls.
 uninit_member: Non-static class member len is not initialized in
  this constructor nor in any functions that it calls.
 uninit_member: Non-static class member lg is not initialized in
  this constructor nor in any functions that it calls.
 uninit_member: Non-static class member completion is not
  initialized in this constructor nor in any functions that it calls.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
test_rgw_admin_opstate.cc: init non-static members in ctor
d46fca5 
Fix for:

CID 1054871 (#1 of 2): Uninitialized pointer field (UNINIT_CTOR)
 uninit_member: Non-static class member curl_inst is not initialized
  in this constructor nor in any functions that it calls.
 uninit_member: Non-static class member resp_code is not initialized
  in this constructor nor in any functions that it calls.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
test_cors.cc: init non-static members in ctor
5d81c9b 
Fix for:

CID 1019635 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
 uninit_member: Non-static class member curl_inst is not initialized
  in this constructor nor in any functions that it calls.
 uninit_member: Non-static class member resp_code is not initialized
  in this constructor nor in any functions that it calls.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
test_rgw_admin_meta.cc: init non-static members in ctor
4e0ea75 
Fix for:

CID 1054872 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
 uninit_member: Non-static class member curl_inst is not initialized
  in this constructor nor in any functions that it calls.
 uninit_member: Non-static class member resp_code is not initialized
  in this constructor nor in any functions that it calls.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
osd/RadosModel.h: init non-static member in ctor
b217d19 
Fix for:

CID 1188182 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
 uninit_member: Non-static class member rcompletion is not initialized
  in this constructor nor in any functions that it calls.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
rbd_replay/Replayer.cc: init non-static members in ctor
19c4c2e 
Fix for:

CID 1232607 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
 uninit_member: Non-static class member m_dump_perf_counters is not
  initialized in this constructor nor in any functions that it calls.
 uninit_member: Non-static class member m_rbd is not initialized in
  this constructor nor in any functions that it calls.
 uninit_member: Non-static class member m_ioctx is not initialized in
  this constructor nor in any functions that it calls.
 uninit_member: Non-static class member m_latency_multiplier is not
  initialized in this constructor nor in any functions that it calls.
 uninit_member: Non-static class member m_readonly is not initialized
  in this constructor nor in any functions that it calls.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
rgw_rados.h: init non-static member of 'struct Params' in ctor
0a5792c 
Fix for:

CID 1274321 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
 uninit_member: Non-static class member perr is not initialized in
  this constructor nor in any functions that it calls.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
rgw_rados.h: init non-static member of 'stat_params' in ctor
1fece68 
Fix for:

CID 1274323 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
 uninit_member: Non-static class member perr is not initialized in
  this constructor nor in any functions that it calls.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
osdc/Journaler.cc: fix integer overflow
56a30cf 
Fix for:

CID 1297861 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
 overflow_before_widen: Potentially overflowing expression
  this->layout.fl_stripe_count.operator __u32() *
  this->layout.fl_object_size.operator __u32() with type unsigned int
  (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used
  in a context that expects an expression of type uint64_t (64 bits, unsigned).

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
mattbenjamin pushed a commit that referenced this pull request Sep 8, 2015
@dalgaaf
mon/OSDMonitor.cc: fix UNINTENDED_INTEGER_DIVISION
be7e07a 
Fix for:

CID 1297885 (#1 of 2): Result is not floating-point (UNINTENDED_INTEGER_DIVISION)
 integer_division: Dividing integer expressions g_conf->mon_pool_quota_warn_threshold
 and 100, and then converting the integer quotient to type float. Any remainder,
 or fractional part of the quotient, is ignored.

CID 1297885 (#2 of 2): Result is not floating-point (UNINTENDED_INTEGER_DIVISION)
 integer_division: Dividing integer expressions g_conf->mon_pool_quota_crit_threshold
 and 100, and then converting the integer quotient to type float. Any remainder,
  or fractional part of the quotient, is ignored.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@mattbenjamin
xio: fix signedness, narrowing, and typos
4bcdc01 
Fix incomplete move of late header computation from XioPortal
send, to _send_message_impl.

Fix an initialization ordering warning, various signedness and
one narrowing mismatch.

Fix spacing around Accelio mempool parameters initialization.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.