Skip to content

fix: add X-Deepin-Singleton flag to desktop file (#392841)#773

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag
Jul 17, 2026
Merged

fix: add X-Deepin-Singleton flag to desktop file (#392841)#773
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag

Conversation

@add-uos

@add-uos add-uos commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Add X-Deepin-Singleton=true to desktop file to mark the application as a singleton app. This allows AM to identify singleton apps and inform Treeland to skip the splash screen for these apps.

Refs: https://pms.uniontech.com/task-view-392841.html

Summary by Sourcery

Enhancements:

  • Add X-Deepin-Singleton=true to the desktop files for data-transfer and dde-cooperation to declare them as singleton apps.

@sourcery-ai

sourcery-ai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Marks the data-transfer and dde-cooperation applications as singletons by adding the X-Deepin-Singleton flag to their Linux desktop entry files, enabling AM/Treeland to skip splash screens for these apps.

File-Level Changes

Change Details Files
Declare the data-transfer application as a singleton via its desktop entry.
  • Add X-Deepin-Singleton=true key to the desktop file to mark the app as singleton for the Deepin environment
  • Ensure the key is placed alongside other Desktop Entry metadata so AM can detect it and Treeland can suppress splash screens
src/apps/data-transfer/res/linux/deepin-data-transfer.desktop
Declare the dde-cooperation application as a singleton via its desktop entry.
  • Add X-Deepin-Singleton=true key to the desktop file to mark the app as singleton for the Deepin environment
  • Ensure the key is placed alongside other Desktop Entry metadata so AM can detect it and Treeland can suppress splash screens
src/apps/dde-cooperation/res/linux/dde-cooperation.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Add X-Deepin-Singleton=true to desktop file to mark the
application as a singleton app.

为单例应用的desktop文件添加X-Deepin-Singleton=true标识。

Log: 添加单例应用标识
PMS: TASK-392841
Influence: AM能识别单例应用,Treeland不再为单例应用显示快速启动画面
@add-uos
add-uos force-pushed the task-392841-add-x-deepin-singleton-flag branch from be6bd89 to a63a535 Compare July 17, 2026 02:42
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:95分

■ 【总体评价】

代码通过添加配置项正确启用了应用单例模式,防止重复启动
逻辑清晰无安全风险,因修改范围极小且无复杂逻辑扣5分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

deepin-data-transfer.desktopdde-cooperation.desktop 中添加了 X-Deepin-Singleton=true,符合 Desktop Entry Specification 的键值对语法规范
潜在问题:无
建议:无需修改

  • 2.代码质量(符合规范)✓

修改位于文件的标准扩展配置区域,紧跟其他 X-Deepin 扩展项,保持了良好的组织和一致性
潜在问题:无
建议:无需修改

  • 3.代码性能(无性能问题)✓

仅增加一行配置文本,对应用启动和运行时的性能没有任何负面影响,反而通过单例模式可能节省系统资源
潜在问题:无
建议:无需修改

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改仅涉及静态配置文件的单行键值对添加,不涉及任何用户输入处理、网络通信或文件系统操作,不存在安全攻击面

  • 建议:无需修改

■ 【改进建议代码示例】

// 当前修改已足够完善,无需额外修复

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
lzwind merged commit 5110319 into linuxdeepin:master Jul 17, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants