fix: revert QML netType rename, register NetType as uncreatable type - #614
Merged
Conversation
Reviewer's GuideRestores the QML-facing type name to NetType and registers it as an uncreatable meta-object so its enums resolve without exposing an instantiable value type, then updates all networking QML references accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
52cyb
force-pushed
the
master
branch
2 times, most recently
from
September 3, 2026 09:27
ad8ae5a to
6545a26
Compare
caixr23
approved these changes
Sep 3, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 52cyb, caixr23 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1. Revert QML registration name "netType" back to "NetType" in dccnetwork.cpp 2. Use qmlRegisterUncreatableMetaObject to expose NetType enums only 3. Revert 101 netType. references to NetType. across 15 QML files Influence: 1. Fix "netType is not defined" ReferenceError at runtime 2. Avoid "value type names should begin with lowercase" warning 3. Confirm NetType enum values resolve correctly in QML fix: 回退 QML netType 重命名,改用不可创建类型注册 NetType 1. 将 dccnetwork.cpp 中 QML 注册名 "netType" 回退为 "NetType" 2. 用 qmlRegisterUncreatableMetaObject 仅暴露 NetType 枚举值 3. 将 15 个 QML 文件中 101 处 netType. 引用回退为 NetType. Influence: 1. 修复运行时 "netType is not defined" ReferenceError 2. 避免出现 "value type names should begin with lowercase" 警告 3. 确认 QML 中 NetType 枚举值解析正确 PMS: TASK-392413
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Influence:
fix: 回退 QML netType 重命名,改用不可创建类型注册 NetType
Influence:
Summary by Sourcery
Restore the NetType QML API and expose its enums without allowing instances to be created.
Bug Fixes:
Enhancements: