Skip to content

chore: update changelog to 2.0.39#1580

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
mhduiy:dev-changelog-2.0.39
Apr 29, 2026
Merged

chore: update changelog to 2.0.39#1580
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
mhduiy:dev-changelog-2.0.39

Conversation

@mhduiy
Copy link
Copy Markdown
Contributor

@mhduiy mhduiy commented Apr 29, 2026

更新说明

自动更新 changelog 到版本 2.0.39

变更内容

  • 更新 debian/changelog

版本信息

  • 新版本: 2.0.39
  • 目标分支: master

Summary by Sourcery

Chores:

  • Bump recorded package version to 2.0.39 in debian changelog metadata.

update changelog to 2.0.39

Log: update changelog to 2.0.39
@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 2.0.39
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 29, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Debian packaging changelog metadata to release version 2.0.39 targeting master.

File-Level Changes

Change Details Files
Bump Debian package changelog entry to version 2.0.39.
  • Add or update the latest changelog stanza to reflect version 2.0.39.
  • Ensure the target distribution/branch metadata in the changelog matches master.
  • Adjust accompanying metadata such as date, maintainer line, or description text as required for the new release entry.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

这段 debian/changelog 的 diff 记录了 dde-shell 项目从版本 2.0.38 升级到 2.0.39 的变更内容。从整体来看,这次更新主要关注于代码质量、内存安全、测试覆盖以及构建系统的维护。

以下是对该变更记录的详细审查意见,分为语法逻辑、代码质量、代码性能和代码安全四个方面:

1. 语法逻辑与版本控制

  • 时间戳异常 (严重)

    • 问题:记录中的日期显示为 Wed, 29 Apr 2026
    • 意见:这是一个明显的逻辑错误,年份写成了 2026 年(未来时间)。这会导致版本控制系统和打包工具在时间排序上产生混乱。
    • 建议:请立即修正为当前实际年份(假设现在是 2024 年或 2025 年),例如 Wed, 29 Apr 2024
  • 变更提交的冗余与回滚 (中等)

    • 问题:日志中出现了以下两行:
      Revert "feat(build): add ENABLE_SANITIZER option for debugging"
      ...
      feat(build): add ENABLE_SANITIZER option for debugging
      
    • 意见:先回滚了一个功能,然后又重新引入了该功能。这通常意味着开发过程中发生了反复,或者合并分支时处理不当。虽然这不影响最终代码的正确性,但会使 Changelog 显得杂乱,难以追踪真正的变更意图。
    • 建议:如果在最终发布的版本中该功能是存在的,应删除 Revert 那一行,只保留最终有效的变更记录。如果是误操作提交,应清理历史记录。
  • 拼写与格式 (轻微)

    • 问题fix:add test notification server applet case by gtest 中,fix: 后面缺少空格。
    • 建议:统一格式,改为 fix: add ...

2. 代码质量

  • 内存管理改进 (优秀)

    • 观察:日志中多次提及内存问题的修复:
      • fix: prevent use-after-free in DataAccessorProxy::setSource
      • fix(dock): fix memory leak in RoleGroupModel
      • fix(test): fix memory leaks in test code
    • 意见:修复 use-after-free(释放后使用)和内存泄漏是提升软件稳定性的关键。这表明开发团队正在积极使用 Valgrind、ASan(AddressSanitizer)或静态分析工具来检查代码。
    • 建议:建议将这些内存检查工具(如 ASan)集成到 CI/CD 流程中,防止未来的提交引入新的内存错误。
  • 测试覆盖增强 (优秀)

    • 观察
      • build(debian): add libgmock-dev to build dependencies
      • fix(dock): ... and add comprehensive tests
      • fix:add test notification server applet case by gtest
    • 意见:引入 Google Mock (GMock) 并增加测试用例,特别是针对 Dock 和通知服务,这对于保证 UI 组件的逻辑正确性非常有帮助。
    • 建议:继续保持增加单元测试和集成测试的习惯,确保核心业务逻辑(如 RoleGroupModel)有充分的测试覆盖。

3. 代码性能

  • 间接影响
    • 观察:虽然日志中没有直接提及 "performance" 或 "optimize",但修复内存泄漏和 use-after-free 本身就是提升长期运行性能的关键。内存泄漏会导致程序长时间运行后占用内存持续增加,最终触发 OOM(Out of Memory)或系统变慢。
    • 建议:无直接建议,当前的修复方向对性能有正面影响。

4. 代码安全

  • 关键漏洞修复 (优秀)

    • 观察fix: prevent use-after-free in DataAccessorProxy::setSource
    • 意见use-after-free 是一类严重的安全漏洞,攻击者可能利用它导致程序崩溃(DoS)甚至执行任意代码(RCE)。修复此问题显著提升了软件的安全性。
    • 建议:审查 DataAccessorProxy 类的指针所有权管理逻辑,考虑使用 C++11 的智能指针(如 std::shared_ptrstd::unique_ptr)来从语言层面杜绝此类错误,而不是依赖人工管理。
  • SPDX 许可证合规 (良好)

    • 观察fix: correct SPDX comment syntax in DDEShellDockConfig.cmake.in 和多处 chore: update copyright...
    • 意见:确保 SPDX 标识符正确有助于自动化工具检查许可证合规性,这对于开源项目分发和法律合规非常重要。

总结建议

  1. 必须修改:将发布日期从 2026 修正为当前实际年份。
  2. 建议清理:移除 Changelog 中关于 ENABLE_SANITIZERRevert 记录,保持历史线性清晰。
  3. 持续改进:鉴于本次提交修复了多处内存问题,建议在后续开发中强制要求新代码通过内存检查工具(如 ASan/LSan)的测试,并优先使用现代 C++ 特性(如智能指针)来管理资源。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wjyrich
Copy link
Copy Markdown
Contributor

wjyrich commented Apr 29, 2026

/forcemerge

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Apr 29, 2026

This pr force merged! (status: blocked)

@deepin-bot deepin-bot Bot merged commit ed5b37c into linuxdeepin:master Apr 29, 2026
10 of 13 checks passed
@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Apr 29, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 2.0.39
  • Tag SHA: 9c7a6bd6dcaf2ffbe66ce1070059b35818815d44
  • Commit SHA: 0e692de1c2a435a1d541bc80ad7e254657bd3e57
  • Tag Message:
    Release dde-shell 2.0.39
    
    
  • Tagger:
    • Name: mhduiy
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants