restore fashion mail card and real monitor stats#1586
Open
shule1987 wants to merge 1 commit intolinuxdeepin:masterfrom
Open
restore fashion mail card and real monitor stats#1586shule1987 wants to merge 1 commit intolinuxdeepin:masterfrom
shule1987 wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @shule1987, your pull request is larger than the review limit of 150000 diff characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shule1987 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 2.0.38 |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
shule1987
force-pushed
the
pr/fashion-dock-polish
branch
from
755908e to
dd1f2e2
Compare
Author
|
recheck cla |
shule1987
force-pushed
the
pr/fashion-dock-polish
branch
from
d456fa5 to
1df5def
Compare
Keep the fashion mode mail plugin visible without waking the mail client when no mailbox account is configured, and read CPU and memory usage from /proc so the monitor plugin reports real values instead of stale fallback data. This revision also trims the PR back to dock-focused fashion mode changes so the GitHub diff stays below the cppcheck action limit, and refreshes the REUSE/SPDX metadata required by the current CI checks.
shule1987
force-pushed
the
pr/fashion-dock-polish
branch
from
1df5def to
14c6d60
Compare
deepin pr auto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two regressions in the fashion dock left
plugins:
was configured.
usage, and memory could stay at a fake
7%value.Background
The original requirement for mail was only to avoid frequently
waking the mail service when no account is configured. During
later polish, that behavior was tightened too much and turned
into:
For the monitor card, the UI was falling back to
org.deepin.SystemMonitorDaemonvalues in cases where/procdata should have been used directly. In practice, the daemon
could return stale placeholder values, and
/proc/meminfoparsing also failed because
QFile::atEnd()is unreliable forprocfs pseudo files.
Changes
Mail card
even when no mail account is configured
service during background refresh
mail client directly
because no account is configured
Monitor stats
/procfor CPU andmemory usage
SystemMonitorDaemonwhen direct readsfail
/proc/meminfoparsing by reading lines untilreadLine()is empty instead of relying onatEnd()MemAvailableis missingguest/guest_nicefrom total time to avoid double counting