fix: pass QJsonParseError to QJsonDocument::fromJson in fromJsonString

[MyLeeJiEun]

Summary

Pass &error to QJsonDocument::fromJson in DPluginMetaData::fromJsonString so the QJsonParseError error branch becomes reachable. Fixes a dead-code defect where malformed JSON was silently swallowed and the qCWarning diagnostic never fired.

Change

• frame/pluginmetadata.cpp: QJsonDocument::fromJson(data) → QJsonDocument::fromJson(data, &error) in fromJsonString.

Behavior

• Valid JSON: no change.
• Malformed JSON: now hits the error branch, logs qCWarning with the parse error string, and returns an invalid DPluginMetaData (previously returned invalid via the missing-Id path, silently).

Testing

• Existing DPluginMetaData.FromJsonStringMalformed unit test still passes — it asserts an invalid result both before and after the fix, so no test update is needed. The previously-unreachable error branch is now reachable for coverage.

Related

• Multica issue: DDE-132

Summary by Sourcery

Make JSON parsing errors reachable so malformed plugin metadata is rejected with diagnostic logging.

Bug Fixes:

• Ensure malformed JSON is reported and rejected with a parse warning in DPluginMetaData::fromJsonString.

Chores:

• Update the plugin metadata source copyright year range.

[deepin-ci-robot]

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR wires QJsonParseError into DPluginMetaData::fromJsonString so JSON parsing failures are correctly detected, logged, and routed through the existing error branch instead of being silently ignored.

Sequence diagram for updated JSON parsing in DPluginMetaData::fromJsonString

sequenceDiagram
    participant Caller
    participant DPluginMetaData
    participant QJsonDocument
    participant Logger

    Caller->>DPluginMetaData: fromJsonString(data)
    activate DPluginMetaData
    DPluginMetaData->>QJsonDocument: fromJson(data, &error)
    QJsonDocument-->>DPluginMetaData: QJsonDocument

    alt [error.error]
        DPluginMetaData->>Logger: qCWarning(dsLog)
        DPluginMetaData-->>Caller: DPluginMetaData()
    else [no parse error]
        DPluginMetaData-->>Caller: DPluginMetaData (from metaData)
    end
    deactivate DPluginMetaData

Loading

File-Level Changes

Change	Details	Files
Make JSON parse errors in DPluginMetaData::fromJsonString detectable and logged by passing QJsonParseError to QJsonDocument::fromJson.	Introduce a local QJsonParseError variable in fromJsonString and pass its address to QJsonDocument::fromJson when creating the QJsonObject. Reuse the existing error handling branch that checks error.error, now correctly triggered on malformed JSON. Preserve existing behavior for valid JSON while improving diagnostics and coverage for malformed JSON inputs.	frame/pluginmetadata.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment