Feat: [cpu] Add max boost clock item on special cpu type. - #713
Conversation
|
Warning
详情 {
"dmidecode": {
"deepin-devicemanager/src/DeviceManager/DeviceCpu.cpp": [
" // \u7279\u6b8a\u673a\u578b\uff0c\u901a\u8fc7 dmidecode \u83b7\u53d6\u6700\u5927\u52a0\u901f\u9891\u7387"
]
}
} |
deepin pr auto review★ 总体评分:95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // main.cpp
if(dconfig && dconfig->isValid()) {
if (dconfig->keyList().contains("specialComType"))
Common::specialComType = dconfig->value("specialComType").toInt();
if (dconfig->keyList().contains("TomlFilesName")) {
QString tomlFilesName = dconfig->value("TomlFilesName").toString();
Common::tomlFilesNameSet(tomlFilesName);
}
if (dconfig->keyList().contains("specialCpuType")) {
int cpuTypeValue = dconfig->value("specialCpuType").toInt();
// 增加枚举边界校验
if (cpuTypeValue >= Common::kUnknowCpuType && cpuTypeValue <= Common::kSpecialCpuType1) {
Common::curCpuType = static_cast<Common::SpecialCpuType>(cpuTypeValue);
} else {
Common::curCpuType = Common::kUnknowCpuType;
}
}
}
// DeviceCpu.cpp
// 可以考虑增加一个内联函数或宏来简化判断,例如:
// bool DeviceCpu::isSpecialCpuType1() const { return Common::curCpuType == Common::kSpecialCpuType1; }
// 然后在 loadTableHeader 和 loadTableData 中调用 isSpecialCpuType1() |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
-- Add max boost clock item on special cpu type.
pick from: 6924401
Log: add feature
Task: https://pms.uniontech.com/task-view-384577.html