fix(vnote): use folder ids for notebook operations#404
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @dengzhongyuan365-dev, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
deepin pr auto review★ 总体评分：88分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 function updateFolderCountsById(folderIdToCount) {
for (var i = 0; i < folderListView.model.count; i++) {
var folder = folderListView.model.get(i);
var fidStr = folder.folderId.toString();
var newCount = folderIdToCount[fidStr];
if (newCount !== undefined) {
folder.count = Number(newCount).toString();
}
}
}
function adjustFolderCountById(folderId, delta) {
for (var i = 0; i < folderListView.model.count; i++) {
var folder = folderListView.model.get(i);
if (Number(folder.folderId) === Number(folderId)) {
var oldCount = Number(folder.count);
folder.count = (oldCount + Number(delta)).toString();
return true;
}
}
return false;
}
onMoveFinishedByFolderId: function(noteIds, srcFolderId, dstFolderId, folderIdToCount) {
updateFolderCountsById(folderIdToCount);
var sortedArray = sortDescending(itemListView.selectedNoteItem);
for (var i = 0; i < sortedArray.length; i++) {
itemListView.model.remove(sortedArray[i]);
}
itemListView.selectedNoteItem = [];
if (folderCountById(srcFolderId) === 0) {
webEngineView.webVisible = false;
} else {
webEngineView.webVisible = true;
}
} |
Unify notebook operations across QML/C++ on stable folderId semantics instead of mixing UI indexes with internal sort indexes.\n\nAlso reset empty-folder startup/delete state to the initial create page and add a regression checklist for affected PMS bugs.\n\nLog: 修复记事本删除、移动和空状态下 folderId/index 语义错位问题\nInfluence: 记事本删除、移动笔记数量、快速创建笔记归属、空列表初始页和相关回归清单。 pms: BUG-320469
7c624d9 to
6619fa3
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
3 similar comments
|
/forcemerge |
|
/forcemerge |
|
/forcemerge |
|
/merge |
|
This pr force merged! (status: unknown) |
3 similar comments
|
This pr force merged! (status: unknown) |
|
This pr force merged! (status: unknown) |
|
This pr force merged! (status: unknown) |
|
This pr cannot be merged! (status: unknown) |
3 participants
Unify notebook operations across QML/C++ on stable folderId semantics instead of mixing UI indexes with internal sort indexes.\n\nAlso reset empty-folder startup/delete state to the initial create page and add a regression checklist for affected PMS bugs.\n\nLog: 修复记事本删除、移动和空状态下 folderId/index 语义错位问题\nInfluence: 记事本删除、移动笔记数量、快速创建笔记归属、空列表初始页和相关回归清单。
pms: BUG-320469