Skip to content

fix: remove yaml literal block scalar in linglong.yaml description#408

Closed
add-uos wants to merge 1 commit into
linuxdeepin:masterfrom
add-uos:feature/fix-BUG370559
Closed

fix: remove yaml literal block scalar in linglong.yaml description#408
add-uos wants to merge 1 commit into
linuxdeepin:masterfrom
add-uos:feature/fix-BUG370559

Conversation

@add-uos

@add-uos add-uos commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • 修复 linglong.yamldescription 字段使用 YAML | 块标量语法导致 ll-cli list 命令下描述信息显示异常的问题
  • description 从多行块标量格式改为普通字符串格式,去掉 4 空格缩进

Bug

PMS: BUG-370559

通过 ll-cli list 命令查看语音记事本信息时,描述信息显示有多余前导空格。

Test plan

  • 执行 ll-cli list 确认语音记事本描述信息显示正常,无多余空格

Summary by Sourcery

Bug Fixes:

  • Correct leading whitespace in the ll-cli list description output by removing YAML block scalar usage for the description field.

Use plain string format for description field to fix
incorrect display in ll-cli list output.

移除 linglong.yaml description 的 YAML 块标量语法,
修复 ll-cli list 命令下描述信息显示异常。

Log: 修复 linglong.yaml 描述信息显示有误
PMS: BUG-370559
Influence: ll-cli list 命令查看语音记事本描述信息时显示正常。
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the linglong.yaml package description format to avoid extra leading spaces in ll-cli list output by replacing a YAML block scalar with a single-line string.

File-Level Changes

Change Details Files
Normalize the package description field in linglong.yaml from a YAML block scalar to a single-line string to fix display issues in ll-cli list.
  • Replaced the description field’s block scalar syntax (using
and indented multiline text) with a standard single-line string value.
  • Removed the four-space indentation previously required by the block scalar, eliminating unintended leading spaces in rendered output.

  • Tips and commands

    Interacting with Sourcery

    • Trigger a new review: Comment @sourcery-ai review on the pull request.
    • Continue discussions: Reply directly to Sourcery's review comments.
    • Generate a GitHub issue from a review comment: Ask Sourcery to create an
      issue from a review comment by replying to it. You can also reply to a
      review comment with @sourcery-ai issue to create an issue from it.
    • Generate a pull request title: Write @sourcery-ai anywhere in the pull
      request title to generate a title at any time. You can also comment
      @sourcery-ai title on the pull request to (re-)generate the title at any time.
    • Generate a pull request summary: Write @sourcery-ai summary anywhere in
      the pull request body to generate a PR summary at any time exactly where you
      want it. You can also comment @sourcery-ai summary on the pull request to
      (re-)generate the summary at any time.
    • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
      request to (re-)generate the reviewer's guide at any time.
    • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
      pull request to resolve all Sourcery comments. Useful if you've already
      addressed all the comments and don't want to see them anymore.
    • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
      request to dismiss all existing Sourcery reviews. Especially useful if you
      want to start fresh with a new review - don't forget to comment
      @sourcery-ai review to trigger a new review!

    Customizing Your Experience

    Access your dashboard to:

    • Enable or disable review features such as the Sourcery-generated pull request
      summary, the reviewer's guide, and others.
    • Change the review language.
    • Add, remove or edit custom review instructions.
    • Adjust other review settings.

    Getting Help

    @deepin-ci-robot

    Copy link
    Copy Markdown

    deepin pr auto review

    ★ 总体评分:100分

    ■ 【总体评价】

    代码修改正确,将YAML多行字符串描述改为单行字符串,语法无误。
    各维度均无问题,无安全漏洞,给予满分。

    ■ 【详细分析】

    • 1.语法逻辑完全正确 ✓

    修改将 description: | 改为 description: ,符合YAML语法规范,将块标量转换为单行字符串标量。
    潜在问题:无
    建议:无需修改

    • 2.代码质量良好 ✓

    描述信息简短,使用单行字符串更加简洁,消除了不必要的多行换行符。
    潜在问题:无
    建议:无需修改

    • 3.代码性能无性能问题 ✓

    配置文件的描述字段修改对运行时性能无任何影响。
    潜在问题:无
    建议:无需修改

    • 4.代码安全存在0个安全漏洞 ✓

    漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
    本次修改仅涉及配置文件的描述文本格式调整,不存在任何外部输入交互或执行逻辑,无安全风险。
    建议:无需修改

    ■ 【改进建议代码示例】

    # 当前代码已足够优秀,无需进一步修改
    package:
      name: deepin-voice.note
      version: 5.10.11
      kind: app
      description: voice note for deepin os
    
    runtime:
      id: org.deepin.Runtime

    @github-actions

    Copy link
    Copy Markdown
    • 敏感词检查失败, 检测到1个文件存在敏感词
    详情
    {
        "linglong.yaml": [
            {
                "line": "  url: \"http://gerrit.uniontech.com/deepin-voice-note\"",
                "line_number": 64,
                "rule": "S35",
                "reason": "Url link | 58e6d4a7c1"
            }
        ]
    }

    @sourcery-ai sourcery-ai Bot left a comment

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hey - I've reviewed your changes and they look great!


    Sourcery is free for open source - if you like our reviews please consider sharing them ✨
    Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

    @add-uos add-uos closed this Jul 17, 2026
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants