Skip to content

fix: remove yaml literal block scalar in linglong.yaml#409

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:develop/snipefrom
add-uos:feature/fix-BUG370559
Jul 17, 2026
Merged

fix: remove yaml literal block scalar in linglong.yaml#409
deepin-bot[bot] merged 1 commit into
linuxdeepin:develop/snipefrom
add-uos:feature/fix-BUG370559

Conversation

@add-uos

@add-uos add-uos commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Use plain string format for description field to fix incorrect display in ll-cli list output.

移除 linglong.yaml description 的 YAML 块标量语法,修复 ll-cli list 命令下描述信息显示异常。

Log: 修复 linglong.yaml 描述信息显示有误
PMS: BUG-370559
Influence: ll-cli list 命令查看语音记事本描述信息时显示正常。

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @add-uos, your pull request is larger than the review limit of 150000 diff characters

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 6.0.20
EXISTED: yes
DISTRIBUTION: unstable

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions

Copy link
Copy Markdown
  • 检测到debian目录文件有变更: debian/control

@github-actions

Copy link
Copy Markdown
  • 敏感词检查失败, 检测到3个文件存在敏感词
详情
{
    "linglong.yaml": [
        {
            "line": "  url: \"http://gerrit.uniontech.com/deepin-voice-note\"",
            "line_number": 64,
            "rule": "S35",
            "reason": "Url link | 58e6d4a7c1"
        }
    ],
    "src/views/vnotemainwindow.cpp": [
        {
            "line": "            url = \"https://www.deepin.org/zh/agreement/privacy/\";",
            "line_number": 1922,
            "rule": "S35",
            "reason": "Url link | 20e2eab189"
        },
        {
            "line": "            url = \"https://www.uniontech.com/agreement/privacy-cn\";",
            "line_number": 1924,
            "rule": "S35",
            "reason": "Url link | 4850a00dd7"
        },
        {
            "line": "            url = \"https://www.deepin.org/en/agreement/privacy/\";",
            "line_number": 1928,
            "rule": "S35",
            "reason": "Url link | 38d42f63bf"
        },
        {
            "line": "            url = \"https://www.uniontech.com/agreement/privacy-en\";",
            "line_number": 1930,
            "rule": "S35",
            "reason": "Url link | f82409d3b5"
        }
    ],
    "assets/web/js/summernote_v9_2.js": [
        {
            "line": "    var KEY_BOGUS = 'bogus';",
            "line_number": 3943,
            "rule": "S106",
            "reason": "Var naming | 6d7db7168d"
        },
        {
            "line": "                    .attr('src', 'https://instagram.com/p/' + igMatch[1] + '/embed/')",
            "line_number": 6957,
            "rule": "S35",
            "reason": "Url link | dcb31e9ddf"
        },
        {
            "line": "                    .attr('src', 'http://v.qq.com/iframe/player.html?vid=' + vid + '&auto=0');",
            "line_number": 6994,
            "rule": "S35",
            "reason": "Url link | ce631f8419"
        }
    ]
}

Use plain string format for description field to fix
incorrect display in ll-cli list output.

移除 linglong.yaml description 的 YAML 块标量语法,
修复 ll-cli list 命令下描述信息显示异常。

Log: 修复 linglong.yaml 描述信息显示有误
PMS: BUG-370559
Influence: ll-cli list 命令查看语音记事本描述信息时显示正常。
@add-uos
add-uos force-pushed the feature/fix-BUG370559 branch from 0e27170 to 3e8cc9a Compare July 17, 2026 07:27
@add-uos add-uos changed the title fix: remove yaml literal block scalar in linglong.yaml description fix: remove yaml literal block scalar in linglong.yaml Jul 17, 2026
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码修复了玲珑包配置文件中description字段类型不匹配的问题,使其符合多行字符串规范
逻辑正确且无安全漏洞,完美解决了类型解析异常的BUG

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

linglong.yaml文件中package.description字段的值从纯数字4修改为YAML多行字符串标识符|,符合Go语言yaml解析器对string类型的严格校验要求,避免了反序列化阶段的类型转换失败。
潜在问题:无
建议:无需额外修改,当前格式已符合玲珑包规范

  • 2.代码质量(良好)✓

修改后的配置文件结构清晰,使用了标准的YAML多行字符串语法,保留了原有的描述文本"voice note for deepin os",符合配置文件编写规范。
潜在问题:无
建议:建议在后续开发中增加配置文件的CI校验,防止类似类型错误再次提交

  • 3.代码性能(无性能问题)✓

配置文件解析不涉及复杂算法或高频调用,修改字段类型对解析性能无负面影响,反而避免了因类型不匹配导致的解析异常中断。
潜在问题:无
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改仅涉及配置文件字符串类型的规范化,不存在外部输入注入或敏感信息泄露风险。

  • 建议:无需针对安全进行额外修复

■ 【改进建议代码示例】

# 当前修改已完全符合规范,无需进一步调整
package:
  name: deepin-voice-note
  version: 6.5.62.1
  kind: app
  description: |
    voice note for deepin os

command:

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@add-uos

add-uos commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@deepin-bot
deepin-bot Bot merged commit 33dd283 into linuxdeepin:develop/snipe Jul 17, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants