Repository navigation
Fix crashes on enum methods, varargs calls and calls on a call result - #420
Merged
Merged
Conversation
ExternalRefinementTypeChecker skips classes and records (user code) but
walked into enums, whose methods have no external target: any program
declaring an enum with a method crashed with a NullPointerException
("qualifiedName" is null).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mapInvocation and checkParameters indexed the parameters by argument
position, so a varargs call with more arguments than parameters (e.g.
logger.debug("{} {}", a, b)) failed with IndexOutOfBoundsException. The
arguments collected into the varargs array are left out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In a.get().m(), when get() has no return refinement its TARGET metadata is its own receiver (a), not the value it returns, and m() was checked against a: "Argument Mismatch Error ... expected Door, got Holder". The receiver is now a fresh value of get()'s type, in an unknown state, created once per call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CatarinaGamboa
force-pushed
the
fix/enum-methods-external-checker
branch
from
October 24, 2026 22:39
d3f6745 to
de56949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three crashes on ordinary Java code, met together in one real class (JabRef's
EditAction). One commit each.1. An enum with a method crashes the verifier
ExternalRefinementTypeCheckerskips classes and records (user code) but not enums, so it visits the enum's methods with no external target. Fix: a no-opvisitCtEnum, as for records.2. A varargs call with more arguments than parameters
mapInvocationandcheckParametersindex the parameters by argument position. Fix: both use only the arguments bound one to one to parameters; the ones collected into the varargs array are left out (an array parameter's refinement is not checked per element anyway).3. A call on the result of a call without a return refinement
When
get()has no return refinement, itsTARGETmetadata is still its own receiver (holder), andprepareInvocationTargetused it as the receiver ofclose(). Fix: a call whoseTARGETis not its return value (RETURN_VAR_NAME) gives a fresh receiver of the call's type, in an unknown state, created once per call (Keys.RECEIVER, as for constructor calls). Now:found true but expected open(#fresh).Tests
CorrectEnumWithMethod: crashed before.CorrectVarargsCall(more, fewer and an explicit array) andErrorVarargsCall(a refined fixed parameter before the varargs is still checked): crashed before.CorrectCallResultReceiver(a call with no precondition on a call result) andErrorCallResultReceiver(reported as a state error, not an argument mismatch).mvn test: 463 tests, 0 failures.Found on a real fixed bug: JabRef's Edit command calling
undo()/redo()withoutcanUndo()/canRedo()(PR JabRef/jabref#9777). We also checked 53 exercises built from real OSS bugs on main (69895fa) and with these changes: the results are identical.🤖 Generated with Claude Code