-
Notifications
You must be signed in to change notification settings - Fork 326
Support AssemblyAI inference context carryover #2057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rosetta-livekit-bot
wants to merge
1
commit into
main
Choose a base branch
from
interim-prevue-pate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+217
−23
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@livekit/agents': patch | ||
| --- | ||
|
|
||
| Support AssemblyAI inference STT agent context carryover. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Turned-off conversation context can still be applied to a speech model that rejects it
The assistant reply is written into the speech engine's context option (
updateOptions({ modelOptions: { agent_context: text } })atagents/src/inference/stt.ts:654) without first checking whether context carryover is actually enabled, so a model that had carryover turned off can still have the context applied.Impact: A speech model configured without carryover (or one that doesn't support it) can still receive assistant context, which for unsupported models can cause the transcription request to be rejected or behave unexpectedly.
How the capability guard is bypassed via the fallback adapter
The base implementation
agents/src/stt/stt.ts:265-275guards onthis.#capabilities.chatContextand warn-and-skips when carryover is unsupported/disabled. The agent activity only registers the forwarder when the STT's ownchatContextcapability is true (agents/src/voice/agent_activity.ts:624), so a directly-used inference STT with carryover disabled is safe.However,
FallbackAdapter._pushConversationItem(agents/src/stt/fallback_adapter.ts:199-204) forwards the item to every wrapped STT, explicitly relying on the comment that "unsupported ones warn-and-skip internally". Its ownchatContextcapability is true if any child supports it (agents/src/stt/fallback_adapter.ts:144). Because this inference override does not callsuper._pushConversationItemand does not checkthis.capabilities.chatContext, a wrapped inference STT whose carryover is disabled (unsupported model,agentContextCarryover: false, orprevious_context_n_turns: 0) will still setagent_contextin itsmodelOptions, which is then sent to the gateway even thoughagent_contextis only supported for the U3 Pro carryover models.Was this helpful? React with 👍 or 👎 to provide feedback.