Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-ducks-yell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@livekit/rtc-node': patch
---

Convert data streams to use livekit-ffi exposed data streams interface
2 changes: 1 addition & 1 deletion packages/livekit-rtc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"dependencies": {
"@datastructures-js/deque": "1.0.8",
"@livekit/mutex": "^1.0.0",
"@livekit/rtc-ffi-bindings": "0.12.60",
"@livekit/rtc-ffi-bindings": "0.12.71",
"@livekit/typed-emitter": "^3.0.0",
"pino": "^9.0.0",
"pino-pretty": "^13.0.0"
Expand Down
10 changes: 8 additions & 2 deletions packages/livekit-rtc/src/data_streams/stream_reader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ export class ByteStreamReader extends BaseStreamReader<ByteStreamInfo> {
// consumer never calls return() (e.g. breaking out of for-await).
reader.releaseLock();
log.error('error processing stream update: %s', error);
return { done: true, value: undefined as unknown };
// Propagate abnormal termination (e.g. remote abort, payload over
// the receiver's size limit) instead of presenting the truncated
// payload as a clean EOF.
throw error;
}
},

Expand Down Expand Up @@ -153,7 +156,10 @@ export class TextStreamReader extends BaseStreamReader<TextStreamInfo> {
reader.releaseLock();
receivedChunks.clear();
log.error('error processing stream update: %s', error);
return { done: true, value: undefined };
// Propagate abnormal termination (e.g. remote abort, payload over
// the receiver's size limit) instead of presenting the truncated
// payload as a clean EOF.
throw error;
}
},

Expand Down
6 changes: 6 additions & 0 deletions packages/livekit-rtc/src/data_streams/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ export interface TextStreamOptions extends DataStreamOptions {
export interface ByteStreamOptions extends DataStreamOptions {
name?: string;
onProgress?: (progress: number) => void;
/**
* Whether the payload may be compressed on the wire. Defaults to true;
* compression is only applied when it actually reduces the payload size
* and every recipient supports it.
*/
compress?: boolean;
}

export type ByteStreamHandler = (
Expand Down
Loading
Loading