Bump livekit-ffi to latest#698
Draft
1egoman wants to merge 1 commit into
Draft
Conversation
…a streams v1 support is advertised The node and python sdks today have their own data streams implementations. If the livekit-ffi upgrade in node-sdks were done today, then it would mean that the new client_protocol=2 would be advertised, and these pre-existing implementations would receive data stream v2 messages, not v1 (ie, single packet data streams, compression, etc). So for now, add a flag which can be set in livekit-ffi to disable advertising the new client protocol so this can be merged. Once merged, node and python can be updated to pass this flag and the livekit-ffi package can be updated. Then, once data streams v2 is done on both node + python and both are updated, this flag can be removed by reverting this commit.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
The
livekit-ffiversion is not updated in this yet.Updates
livekit-ffito the latest version, which contains data streams v2.In addition to the ffi package update itself, there's a bit more that has to be done here because the node sdks today has its own data streams implementation. I'm working on migrating this package to use the
livekit-ffiprovided data streams but in the meantime, if thelivekit-ffiwas done today, then it would mean that the newly introducedclient_protocolof2would be advertised, and the pre-existing node implementation would receive data stream v2 messages, not v1 (ie, single packet data streams, compression, etc could be sent to the existing node data streams code).To address this, I've added a temporary
useLegacyClientImplementationflag which can be set to disable advertising the new client protocol. What this means in practice:client_protocolof1, so no inline content / compression)livekit-ffi's data streams implementation, just like it works today)Once #697 is done, I'll merge it and drop this flag both here and on the rust sdk end, and then everything will use data streams v2 everywhere.
I've tested this locally (all the data streams and rpc paths above) with success.
Todo
livekit-ffirelease