Skip to content

Update github workflows #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update github workflows #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
run:
working-directory: ${{ env.PACKAGE_DIR }}
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true

Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
name: api-release
path: dist

- uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b # release/v1
- uses: pypa/gh-action-pypi-publish@dc37677b2e1c63e2034f94d8a5b11f265b73ba33 # release/v1

docs:
needs: [publish]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: recursive

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-protocol.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
run:
working-directory: ${{ env.PACKAGE_DIR }}
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true
ref: ${{ github.event.pull_request.head.ref }}
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
run:
working-directory: ${{ env.PACKAGE_DIR }}
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true

Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
name: protocol-release
path: dist

- uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b # release/v1
- uses: pypa/gh-action-pypi-publish@dc37677b2e1c63e2034f94d8a5b11f265b73ba33 # release/v1

docs:
needs: [publish]
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-rtc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
run:
working-directory: ${{ env.PACKAGE_DIR }}
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true
ref: ${{ github.event.pull_request.head.ref }}
Expand Down Expand Up @@ -75,14 +75,14 @@ jobs:
run:
working-directory: ${{ env.PACKAGE_DIR }}
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true

- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7
id: setup-python
with:
python-version: "3.11"
python-version: "3.14"

@devin-ai-integration devin-ai-integration Bot Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: cibuildwheel host interpreter bump is independent of built wheel targets

The python-version: 3.14 here only selects the interpreter that pipx run uses to launch cibuildwheel; the set of built wheel ABIs is controlled by cibuildwheel config/CIBW_ARCHS, so the produced artifacts (and the 3.9–3.14 test matrix below) are unaffected. Same reasoning applies to .github/workflows/publish.yml:227.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


- name: Build wheels
run: pipx run --python '${{ steps.setup-python.outputs.python-path }}' cibuildwheel==3.3.1 --output-dir dist
Expand All @@ -101,7 +101,7 @@ jobs:
run:
working-directory: ${{ env.PACKAGE_DIR }}
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true

Expand Down Expand Up @@ -187,7 +187,7 @@ jobs:
path: dist
merge-multiple: true

- uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b # release/v1
- uses: pypa/gh-action-pypi-publish@dc37677b2e1c63e2034f94d8a5b11f265b73ba33 # release/v1

docs:
needs: [publish]
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/check-types.yml
View file
Open in desktop

@devin-ai-integration devin-ai-integration Bot Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Type-checking job downloads native library into a nonexistent Python folder after version upgrade

The native library download destination is hardcoded to a Python 3.9 folder (.venv/lib/python3.9/... at .github/workflows/check-types.yml:38) even though the job now sets up Python 3.14, so the files land in the wrong place and are never picked up.
Impact: The Check Types CI job can no longer find the downloaded library and fails or type-checks against a broken install.

Version mismatch between setup-python and hardcoded venv path

The step at .github/workflows/check-types.yml:20-23 was changed to install Python 3.14, but the download step at .github/workflows/check-types.yml:38 still writes to .venv/lib/python3.9/site-packages/livekit/rtc/resources. Since uv sync (.github/workflows/check-types.yml:32) creates .venv using the active 3.14 interpreter, the real site-packages path is .venv/lib/python3.14/site-packages/.... The download_ffi.py --output path therefore points to a directory that is not on the interpreter's import path, so livekit.rtc resources are missing when mypy runs at .github/workflows/check-types.yml:41. Previously (with Python 3.9) the two matched. The path must track the configured Python minor version.

(Refers to line 38)

Prompt for agents 
In .github/workflows/check-types.yml the 'Set up Python' step was bumped to python-version 3.14, but the 'Download ffi' step (line 38) still hardcodes the output path .venv/lib/python3.9/site-packages/livekit/rtc/resources. Because uv sync creates the .venv using the 3.14 interpreter, the actual site-packages directory is .venv/lib/python3.14/site-packages, so the ffi resources are downloaded into a directory that is not on the import path and mypy will not find them. Fix by making the path track the configured Python version, e.g. derive the site-packages directory dynamically (using `uv run python -c 'import livekit.rtc, os; print(...)'` or `python -c 'import sysconfig'`) instead of hardcoding python3.9. Also consider updating the stale step name 'Set up Python 3.9'.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,17 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: recursive

- name: Set up Python 3.9
uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7
with:
python-version: 3.9
python-version: 3.14

@devin-ai-integration devin-ai-integration Bot Apr 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Hardcoded python3.9 path in FFI download step not updated after Python version bump to 3.14

The Python version was bumped from 3.9 to 3.14 on line 23, but the Download ffi step on line 38 still uses a hardcoded path .venv/lib/python3.9/site-packages/livekit/rtc/resources. Since uv sync creates the venv with Python 3.14, the actual site-packages directory will be .venv/lib/python3.14/..., so the FFI resources get written to a non-existent/wrong directory. This causes the subsequent Check Types step (mypy) to fail because it won't find the native FFI libraries.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


- name: Install uv
uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
uses: astral-sh/setup-uv@11f9893b081a58869d3b5fccaea48c9e9e46f990 # v8.3.2
with:
enable-cache: true
cache-dependency-glob: "uv.lock"
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
if: github.event_name == 'workflow_dispatch'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
ref: ${{ inputs.branch }}
submodules: true
Expand All @@ -68,7 +68,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7
with:
python-version: "3.10"
python-version: "3.14"

- name: Install dependencies
run: pip install click packaging
Expand Down Expand Up @@ -182,7 +182,7 @@ jobs:
needs: detect
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
ref: ${{ github.event.pull_request.merge_commit_sha }}

Expand Down Expand Up @@ -217,14 +217,14 @@ jobs:
run:
working-directory: ./livekit-rtc
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true

- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7
id: setup-python
with:
python-version: "3.11"
python-version: "3.14"

- name: Build wheels
run: pipx run --python '${{ steps.setup-python.outputs.python-path }}' cibuildwheel==3.3.1 --output-dir dist
Expand All @@ -245,7 +245,7 @@ jobs:
run:
working-directory: ./livekit-rtc
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true

Expand Down Expand Up @@ -279,7 +279,7 @@ jobs:
run: ls -la dist/

- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b # release/v1
uses: pypa/gh-action-pypi-publish@dc37677b2e1c63e2034f94d8a5b11f265b73ba33 # release/v1

# ── API build ────────────────────────────────────────────────
build-api:
Expand All @@ -291,7 +291,7 @@ jobs:
run:
working-directory: ./livekit-api
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true

Expand Down Expand Up @@ -328,7 +328,7 @@ jobs:
run: ls -la dist/

- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b # release/v1
uses: pypa/gh-action-pypi-publish@dc37677b2e1c63e2034f94d8a5b11f265b73ba33 # release/v1

# ── Protocol build ───────────────────────────────────────────
build-protocol:
Expand All @@ -340,7 +340,7 @@ jobs:
run:
working-directory: ./livekit-protocol
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true

Expand Down Expand Up @@ -377,7 +377,7 @@ jobs:
run: ls -la dist/

- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b # release/v1
uses: pypa/gh-action-pypi-publish@dc37677b2e1c63e2034f94d8a5b11f265b73ba33 # release/v1

# ── Docs ─────────────────────────────────────────────────────
docs-rtc:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ruff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7
with:
python-version: "3.9"
python-version: "3.14"
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.

- name: Install uv
uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
uses: astral-sh/setup-uv@11f9893b081a58869d3b5fccaea48c9e9e46f990 # v8.3.2
with:
enable-cache: true
cache-dependency-glob: "uv.lock"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,16 @@ jobs:
- 10001:10001
- 10002:10002
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true

- uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7
with:
python-version: "3.12"
python-version: "3.14"

- name: Install uv
uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
uses: astral-sh/setup-uv@11f9893b081a58869d3b5fccaea48c9e9e46f990 # v8.3.2

- name: Install livekit-api (without livekit-rtc)
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
name: Test (${{ inputs.os }}, Python ${{ inputs.python-version }})
runs-on: ${{ inputs.os }}
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
submodules: true
lfs: true
Expand All @@ -43,7 +43,7 @@ jobs:
allow-prereleases: true

- name: Install uv
uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
uses: astral-sh/setup-uv@11f9893b081a58869d3b5fccaea48c9e9e46f990 # v8.3.2
with:
enable-cache: true
cache-dependency-glob: "uv.lock"
Expand Down