feat(eot): add eot/inference protos#637
Merged
cloudwebrtc merged 4 commits intomainfrom Apr 27, 2026
Merged
Conversation
Member
chenghao-mou
commented
Apr 24, 2026
chenghao-mou
commented
- Updated protocol version/commit
- Add inference protos in the generation script
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Devin Review found 1 potential issue.
🐛 1 issue in files not directly in the diff
🐛 New agent_inference module missing from agent_pb/__init__.py (livekit-protocol/livekit/protocol/agent_pb/__init__.py:1)
The agent_pb/__init__.py (livekit-protocol/livekit/protocol/agent_pb/__init__.py:1) imports agent_dev, agent_session, agent_text but does not include the newly added agent_inference module. All other modules in the agent_pb directory are listed in __init__.py, so this breaks the convention. As a result, from livekit.protocol import agent_pb will not auto-import agent_inference, and users doing agent_pb.agent_inference will get an AttributeError unless they explicitly import it.
View 1 additional finding in Devin Review.
cloudwebrtc
requested review from
xianshijing-lk
and removed request for
xianshijing-lk
longcw
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.