chore(cloudagents): inject attributes header in byoc deploys#951
Merged
rektdeckard merged 3 commits intoJul 15, 2026
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
rektdeckard
force-pushed
the
tobiasfried/ap-956-byoc-deploy-attributes-are-not-persisted-on-agent-versions
branch
from
July 15, 2026 20:19
953e9d5 to
5fedb49
Compare
Contributor
|
Can we do |
yoonsio
approved these changes
Jul 15, 2026
Member
Author
|
@yoonsio sure, makes sense |
rektdeckard
deleted the
tobiasfried/ap-956-byoc-deploy-attributes-are-not-persisted-on-agent-versions
branch
July 15, 2026 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/livekit/issue/AP-956/byoc-deploy-attributes-are-not-persisted-on-agent-versions
What: injects any user-defined deployment attributes as a request header (
X-LIVEKIT-AGENT-ATTRIBUTES) after completing image upload in a BYOC deployment.BYOC agent deployments are currently a 2-step process:
crane) to upload an image to/v2callback endpoint when the push is completeThe cloud-agents service then creates a record of the agent version and spins it up. In order to support custom user-defined attributes in BYOC cloud agent deployments, we have to forward them to cloud-agents svc after pushing the image, because this transaction is stateless from the perspective of cloud-agents svc.
In the Non-BYOC case, which is very similar, we had been appending these attributes as URL parameters. For consistency's sake, I have now standardized both cases to use the header value (with backward compatibility for the parameter).
REF: https://github.com/livekit/cloud-agents/pull/736, livekit/livekit-cli#914