Add livepeer-w3 to catalyst docker image#396
Conversation
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
===================================================
- Coverage 34.32836% 33.79531% -0.53305%
===================================================
Files 4 4
Lines 938 938
===================================================
- Hits 322 317 -5
- Misses 572 579 +7
+ Partials 44 42 -2
Continue to review full report at Codecov.
|
hjpotter92
left a comment
There was a problem hiding this comment.
lgtm. one minor suggestion, if possible; could go-tools generate a package similar to how studio releases livepeer-api and livepeer-www binaries with node dependencies bundled? it'd then simply be a matter of adding a service in manifest which can use the strip build target from this docker manifest.
That would be nice. Though I'm not sure how much work it is to create releases and if it's worth it. For now, I've created a GH Issue: livepeer/go-tools#18 |
We need a nodejs script in order to upload files into web3.storage.
It increases the Docker images size
2.22GB=>2.46GBFor the context, please check this PR: livepeer/go-tools#17
fix #373