examples(upload-modes): WS-disabled e2e for Direct + Volume (#448, #449)#78
Merged
Conversation
Add TestUploadModes_DirectWSDisabled_E2E and TestUploadModes_VolumeWSDisabled_E2E, mirroring the existing Proxied WS-disabled test (stub a dead window.WebSocket to force the HTTP transport). Direct proves the HTTP upload_complete handshake runs the completion action (#448); Volume proves the multipart fallback stages to Dir, retained (#449). Refactor the shared chromium/app/skip setup into helpers and hoist the killWS stub to a package const. Document the WS-disabled behavior in the README and recipe. Tests stay gated on LVT_UPLOAD_MODES_E2E + LVT_LOCAL_CLIENT (verified locally against the unreleased server/client; CI-skipped per docs#67). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…fixes v0.14.0 ships the server side of the upload-modes WS-disabled e2e (#448 Direct completion over HTTP, #449 Volume multipart→Dir), so the committed *WSDisabled_E2E tests now compile and run against the released fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds browser e2e proving all four upload modes complete with the WebSocket disabled, and documents it.
TestUploadModes_DirectWSDisabled_E2E— stubs a deadwindow.WebSocket, selects the Direct file, asserts the presigned PUT lands in the sink and#direct-resultrenders (proves the HTTPupload_completehandshake ran the completion action — livetemplate#448).TestUploadModes_VolumeWSDisabled_E2E— same dead socket, asserts the Volume file is retained understorage/volume(Dir) and#volume-resultrenders the path (livetemplate#449).killWSstub to a package const.Verified locally against the unreleased server (
livetemplate/livetemplate#455) + client (livetemplate/client#132): all four e2e green in Chromium. Tests stay gated onLVT_UPLOAD_MODES_E2E+LVT_LOCAL_CLIENT(CI-skipped per #67).go.modto the new livetemplate so the committed test exercises the released fix.🤖 Generated with Claude Code