Skip to content

Feature/brushup distributed hdbscan #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graceli24 merged 5 commits into from
Oct 14, 2026
Merged

Feature/brushup distributed hdbscan #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab661c8
Add local cache map for min_incident_edge_map to facilitate look ups …
graceli24 Oct 14, 2026
9eb32c2
Remove extra debug timer printouts in ingesting edges
graceli24 Oct 14, 2026
99ed295
Fix a typo
graceli24 Oct 14, 2026
bad3170
Remove extranous code from testing different ways to initialize min i…
graceli24 Oct 14, 2026
41e2f3a
Add timing for initializing min incident edge map, a current bottlene…
graceli24 Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 33 additions & 32 deletions src/clustering/distributed_clustering_build_hierarchy.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ void fill_alpha_edge_map(
if (edge.chain_parent_edge_id > 0) {
chain_supernode = edge.chain_supernode;
}
auto set_info_lambda = [](const id_t &edge_id, alpha_edge_info &edge,
const distance_t &distance,
const supernode_t &chain_supernode) {
edge.distance = distance;
edge.chain_supernode = chain_supernode;
};
auto set_info_lambda =
[]([[maybe_unused]] const id_t &edge_id, alpha_edge_info &edge,
const distance_t &distance, const supernode_t &chain_supernode) {
edge.distance = distance;
edge.chain_supernode = chain_supernode;
};
alpha_edge_map.async_visit(edge_id, set_info_lambda, edge.distance,
chain_supernode);
}
Expand Down Expand Up @@ -437,7 +437,7 @@ void fill_missing_non_root_chain_cluster_info(
// Go through each non-root chain and for each cluster fill in the birth
// distance
auto set_birth_distance_lambda =
[](const supernode_t &chain_name,
[]([[maybe_unused]] const supernode_t &chain_name,
std::pair<std::map<id_t, full_cluster_info>, full_chain_info> &chain) {
// The ith cluster has birth distance equal to the min edge distance of
// the (i+1)th cluster
Expand All @@ -463,12 +463,12 @@ void fill_missing_non_root_chain_cluster_info(
&chain) {
id_t parent_edge_id = chain.second.parent_edge_id;
// Visit the parent edge in the alpha edge map and get its chain
auto visit_alpha_edge_lambda = [](const id_t &edge_id,
auto visit_alpha_edge_lambda = []([[maybe_unused]] const id_t &edge_id,
const alpha_edge_info &edge_info,
const supernode_t &chain_name,
auto chain_map_ptr) {
auto set_parent_chain_and_top_birth_dist =
[](const supernode_t &chain_name,
[]([[maybe_unused]] const supernode_t &chain_name,
std::pair<std::map<id_t, full_cluster_info>, full_chain_info>
&chain,
const supernode_t &parent_chain,
Expand Down Expand Up @@ -511,7 +511,7 @@ void fill_missing_non_root_chain_cluster_info(
}

auto set_bottom_children_lambda =
[](const supernode_t &chain_name,
[]([[maybe_unused]] const supernode_t &chain_name,
std::pair<std::map<id_t, full_cluster_info>, full_chain_info>
&chain,
const std::array<supernode_t, 2> &children) {
Expand All @@ -537,7 +537,7 @@ void fill_missing_non_root_chain_cluster_info(
}

auto set_child_lambda =
[](const supernode_t &chain_name,
[]([[maybe_unused]] const supernode_t &chain_name,
std::pair<std::map<id_t, full_cluster_info>, full_chain_info>
&chain,
const id_t &cluster_edge_id, const supernode_t &child) {
Expand Down Expand Up @@ -588,24 +588,25 @@ void fill_missing_leaf_cluster_info(
const supernode_t &cluster_name,
full_leaf_cluster_info &cluster_info) {
// Visit the parent edge in the alpha edge map and get its chain
auto visit_alpha_edge_lambda =
[](const id_t &edge_id, const alpha_edge_info &edge_info,
const supernode_t &cluster_name, auto leaf_cluster_map_ptr) {
auto set_parent_chain_and_top_birth_dist =
[](const supernode_t &cluster_name,
full_leaf_cluster_info &cluster_info,
const supernode_t &parent_chain,
const distance_t &parent_edge_distance) {
// Set the chain parent
cluster_info.parent_chain = parent_chain;

// Set the birth distance for the last cluster in the chain
cluster_info.birth_distance = parent_edge_distance;
};
leaf_cluster_map_ptr->async_visit(
cluster_name, set_parent_chain_and_top_birth_dist,
edge_info.chain_supernode, edge_info.distance);
};
auto visit_alpha_edge_lambda = []([[maybe_unused]] const id_t &edge_id,
const alpha_edge_info &edge_info,
const supernode_t &cluster_name,
auto leaf_cluster_map_ptr) {
auto set_parent_chain_and_top_birth_dist =
[]([[maybe_unused]] const supernode_t &cluster_name,
full_leaf_cluster_info &cluster_info,
const supernode_t &parent_chain,
const distance_t &parent_edge_distance) {
// Set the chain parent
cluster_info.parent_chain = parent_chain;

// Set the birth distance for the last cluster in the chain
cluster_info.birth_distance = parent_edge_distance;
};
leaf_cluster_map_ptr->async_visit(
cluster_name, set_parent_chain_and_top_birth_dist,
edge_info.chain_supernode, edge_info.distance);
};
alpha_edge_map.async_visit(cluster_info.parent_edge_id,
visit_alpha_edge_lambda, cluster_name,
leaf_cluster_map_ptr);
Expand Down Expand Up @@ -702,7 +703,7 @@ supernode_t fill_missing_root_chain_cluster_info(
[&root_chain_cluster_edges_map, full_root_chain_cluster_array_ptr](
const id_t &index, std::pair<id_t, root_chain_cluster_info> &value) {
auto visit_cluster_edge_map =
[](const id_t &cluster_edge_id,
[]([[maybe_unused]] const id_t &cluster_edge_id,
const std::vector<edge_id_with_dist_t> &edges,
const id_t &array_index,
ygm::ygm_ptr<ygm::container::array<
Expand All @@ -720,7 +721,7 @@ supernode_t fill_missing_root_chain_cluster_info(
// Set the values in the cluster array
full_root_chain_cluster_array_ptr->async_visit(
array_index,
[](const id_t &index,
[]([[maybe_unused]] const id_t &index,
std::pair<id_t, root_chain_cluster_info> &value,
const id_t &num_points_added,
const distance_t
Expand Down Expand Up @@ -787,7 +788,7 @@ supernode_t fill_missing_root_chain_cluster_info(
// Set the child in the root chain cluster array
full_root_chain_cluster_array_ptr->async_visit(
array_index,
[](const id_t &index,
[]([[maybe_unused]] const id_t &index,
std::pair<id_t, root_chain_cluster_info> &value,
const supernode_t &child) { value.second.child = child; },
child);
Expand Down
Loading
Loading