Time history for time-dependent objective - #1634
Open
tlroy wants to merge 1 commit into
Open
Conversation
tupek2
approved these changes
Jul 31, 2026
tupek2
left a comment
tupek2
left a comment
Collaborator
There was a problem hiding this comment.
I think there will be, in the long run, a better way to handle this within smith by putting time actually on the gretl graph. But, that is more involved of a change, so I think we can and should do this for now. For transient problems, lido relies on us for storage, while for static, the handle their own storage. Though a bit strange, having us save the time is consistent with us being on the hook to also save displacement fields (which we already do).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add time history to the new differentiable physics framework. Fixes Issue #1632