Fix/qa

[lloc]

This fixes the return type covariance for MslsOutput.

[github-actions]

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues	❌ Errors	⚠️ Warnings
24	0	24

---

⚠️ Warnings (24)

📁 includes/MslsCustomFilter.php (1 warning)

📍 Line	🔖 Check	💬 Message
86	WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in	Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://wpvip.com/documentation/performance-improvements-by-removing-usage-of-post__not_in/ for more information.

📁 includes/MslsRestApi.php (1 warning)

📍 Line	🔖 Check	💬 Message
405	WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in	Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://wpvip.com/documentation/performance-improvements-by-removing-usage-of-post__not_in/ for more information.

📁 includes/MslsTranslationPickerTable.php (1 warning)

📍 Line	🔖 Check	💬 Message
180	WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in	Using exclusionary parameters, like post__not_in, in calls to get_posts() should be done with caution, see https://wpvip.com/documentation/performance-improvements-by-removing-usage-of-post__not_in/ for more information.

📁 includes/MslsWidget.php (1 warning)

📍 Line	🔖 Check	💬 Message
58	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_ALTERNATIVE_CONTENT_HOOK".

📁 includes/MslsAdmin.php (2 warnings)

📍 Line	🔖 Check	💬 Message
247	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_REGISTER_ACTION".
347	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_ACTION_PREFIX . $section".

📁 includes/Map/HrefLang.php (1 warning)

📍 Line	🔖 Check	💬 Message
69	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_HEAD_HREFLANG_HOOK".

📁 includes/MslsBlog.php (3 warnings)

📍 Line	🔖 Check	💬 Message
143	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_GET_PERMALINK_HOOK".
147	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_GET_PERMALINK_HOOK".
201	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::WP_ADMIN_BAR_SHOW_SITE_ICONS_HOOK".

📁 includes/Component/Input/Select.php (1 warning)

📍 Line	🔖 Check	💬 Message
39	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::RENDER_FILTER".

📁 includes/MslsPostTagClassic.php (2 warnings)

📍 Line	🔖 Check	💬 Message
39	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_ADD_INPUT_ACTION".
71	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_EDIT_INPUT_ACTION".

📁 includes/MslsMain.php (1 warning)

📍 Line	🔖 Check	💬 Message
143	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_SAVE_ACTION".

📁 includes/MslsPostTag.php (2 warnings)

📍 Line	🔖 Check	💬 Message
135	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_ADD_INPUT_ACTION".
170	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_EDIT_INPUT_ACTION".

📁 includes/MslsOutput.php (6 warnings)

📍 Line	🔖 Check	💬 Message
96	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_GET_HOOK".
125	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_ALTERNATE_LINKS_HOOK".
141	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_ALTERNATE_LINKS_DEFAULT_HOOK".
144	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_ALTERNATE_LINKS_ARR_HOOK".
157	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_NO_TRANSLATION_FOUND_HOOK".
188	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_GET_TAGS_HOOK".

📁 includes/ContentImport/ContentImporter.php (2 warnings)

📍 Line	🔖 Check	💬 Message
295	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_BEFORE_IMPORT_ACTION".
356	WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "self::MSLS_AFTER_IMPORT_ACTION".

---

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

[gemini-code-assist]

Code Review

This pull request introduces several updates, including project configuration changes in .gitignore and composer.json, an increase in the PHPStan analysis level to 8, and the addition of Yoruba translations to auto-generated assets. Type hints were also refined in MslsMain and MslsOutput. Feedback identifies a high-severity issue in MslsTranslationPickerTable.php where the removal of a safety check could lead to a fatal error. Furthermore, the reviewer recommends reverting the change from mysql_to_rfc3339() to mysql2date() in MslsRestApi.php to follow WordPress standards.

I am having trouble creating individual review comments. Click here to see my feedback.

includes/MslsTranslationPickerTable.php (161)

The previous implementation was safer by checking if $this->screen is an object before calling get_hidden_columns(). If $this->screen is null, the new code will likely cause a fatal error or warning.

		$hidden                = is_object( $this->screen ) ? get_hidden_columns( $this->screen ) : array();

includes/MslsRestApi.php (423)

mysql_to_rfc3339() is the standard WordPress function for converting MySQL date strings to RFC3339 format. Replacing it with mysql2date() using a hardcoded format string is less readable and more prone to errors.

				'date_gmt'    => mysql_to_rfc3339( $post->post_date_gmt ),

tests/phpunit/TestMslsRestApi.php (278)

This test change should be reverted if the mysql_to_rfc3339() function is restored in the main code.

		Functions\expect( 'mysql_to_rfc3339' )->once()->with( '2026-04-20 12:00:00' )->andReturn( '2026-04-20T12:00:00' );