[AMDLIBM] Remove the mapping of the deleted vector call#193760
Open
rohitaggarwal007 wants to merge 2 commits intollvm:mainfrom
Open
[AMDLIBM] Remove the mapping of the deleted vector call#193760rohitaggarwal007 wants to merge 2 commits intollvm:mainfrom
rohitaggarwal007 wants to merge 2 commits intollvm:mainfrom
Conversation
llvmbot
added
llvm:ir
llvm:analysis
Member
|
@llvm/pr-subscribers-llvm-analysis Author: Rohit Aggarwal (rohitaggarwal007) ChangesRemoving the mapping of deleted vector from the AOCL amdlibm_vec.h Full diff: https://github.com/llvm/llvm-project/pull/193760.diff 2 Files Affected:
diff --git a/llvm/include/llvm/Analysis/VecFuncs.def b/llvm/include/llvm/Analysis/VecFuncs.def
index dfa1b4b7f793d..4addfbf559218 100644
--- a/llvm/include/llvm/Analysis/VecFuncs.def
+++ b/llvm/include/llvm/Analysis/VecFuncs.def
@@ -1803,7 +1803,6 @@ TLI_DEFINE_VECFUNC("__exp10f_finite", "amd_vrs4_exp10f", FIXED(4), NOMASK, "_ZGV
TLI_DEFINE_VECFUNC("llvm.exp10.f64", "amd_vrd2_exp10", FIXED(2), NOMASK, "_ZGV_LLVM_N2v")
TLI_DEFINE_VECFUNC("llvm.exp10.f32", "amd_vrs4_exp10f", FIXED(4), NOMASK, "_ZGV_LLVM_N4v")
-TLI_DEFINE_VECFUNC("expm1", "amd_vrd2_expm1", FIXED(2), NOMASK, "_ZGV_LLVM_N2v")
TLI_DEFINE_VECFUNC("expm1f", "amd_vrs4_expm1f", FIXED(4), NOMASK, "_ZGV_LLVM_N4v")
TLI_DEFINE_VECFUNC("log1p", "amd_vrd2_log1p", FIXED(2), NOMASK, "_ZGV_LLVM_N2v")
diff --git a/llvm/include/llvm/IR/RuntimeLibcalls.td b/llvm/include/llvm/IR/RuntimeLibcalls.td
index a0f505f1fda2f..1d9e91b4587f6 100644
--- a/llvm/include/llvm/IR/RuntimeLibcalls.td
+++ b/llvm/include/llvm/IR/RuntimeLibcalls.td
@@ -4424,7 +4424,6 @@ defset list<RuntimeLibcallImpl> AMDLIBM_VECFUNCS = {
def amd_vrd2_exp : RuntimeLibcallImpl<EXP_V2F64>;
def amd_vrd2_exp10 : RuntimeLibcallImpl<EXP10_V2F64>;
def amd_vrd2_exp2 : RuntimeLibcallImpl<EXP2_V2F64>;
- def amd_vrd2_expm1 : RuntimeLibcallImpl<EXPM1_V2F64>;
def amd_vrd2_log : RuntimeLibcallImpl<LOG_V2F64>;
def amd_vrd2_log10 : RuntimeLibcallImpl<LOG10_V2F64>;
def amd_vrd2_log1p : RuntimeLibcallImpl<LOG1P_V2F64>;
|
Member
|
@llvm/pr-subscribers-llvm-ir Author: Rohit Aggarwal (rohitaggarwal007) ChangesRemoving the mapping of deleted vector from the AOCL amdlibm_vec.h Full diff: https://github.com/llvm/llvm-project/pull/193760.diff 2 Files Affected:
diff --git a/llvm/include/llvm/Analysis/VecFuncs.def b/llvm/include/llvm/Analysis/VecFuncs.def
index dfa1b4b7f793d..4addfbf559218 100644
--- a/llvm/include/llvm/Analysis/VecFuncs.def
+++ b/llvm/include/llvm/Analysis/VecFuncs.def
@@ -1803,7 +1803,6 @@ TLI_DEFINE_VECFUNC("__exp10f_finite", "amd_vrs4_exp10f", FIXED(4), NOMASK, "_ZGV
TLI_DEFINE_VECFUNC("llvm.exp10.f64", "amd_vrd2_exp10", FIXED(2), NOMASK, "_ZGV_LLVM_N2v")
TLI_DEFINE_VECFUNC("llvm.exp10.f32", "amd_vrs4_exp10f", FIXED(4), NOMASK, "_ZGV_LLVM_N4v")
-TLI_DEFINE_VECFUNC("expm1", "amd_vrd2_expm1", FIXED(2), NOMASK, "_ZGV_LLVM_N2v")
TLI_DEFINE_VECFUNC("expm1f", "amd_vrs4_expm1f", FIXED(4), NOMASK, "_ZGV_LLVM_N4v")
TLI_DEFINE_VECFUNC("log1p", "amd_vrd2_log1p", FIXED(2), NOMASK, "_ZGV_LLVM_N2v")
diff --git a/llvm/include/llvm/IR/RuntimeLibcalls.td b/llvm/include/llvm/IR/RuntimeLibcalls.td
index a0f505f1fda2f..1d9e91b4587f6 100644
--- a/llvm/include/llvm/IR/RuntimeLibcalls.td
+++ b/llvm/include/llvm/IR/RuntimeLibcalls.td
@@ -4424,7 +4424,6 @@ defset list<RuntimeLibcallImpl> AMDLIBM_VECFUNCS = {
def amd_vrd2_exp : RuntimeLibcallImpl<EXP_V2F64>;
def amd_vrd2_exp10 : RuntimeLibcallImpl<EXP10_V2F64>;
def amd_vrd2_exp2 : RuntimeLibcallImpl<EXP2_V2F64>;
- def amd_vrd2_expm1 : RuntimeLibcallImpl<EXPM1_V2F64>;
def amd_vrd2_log : RuntimeLibcallImpl<LOG_V2F64>;
def amd_vrd2_log10 : RuntimeLibcallImpl<LOG10_V2F64>;
def amd_vrd2_log1p : RuntimeLibcallImpl<LOG1P_V2F64>;
|
Contributor
Author
|
@RKSimon @phoebewang @fhahn |
Collaborator
|
No tests to remove/change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the mapping of deleted vector from the amdlibm_vec.h