Migrate from the localstack CLI to lstk - #6
Open
HarshCasper wants to merge 1 commit into
Open
Conversation
| DEBUG=1 LOCALSTACK_AUTH_TOKEN=$LOCALSTACK_AUTH_TOKEN localstack start -d | ||
| # Wait 30 seconds for the LocalStack container to become ready before timing out | ||
| LOCALSTACK_DEBUG=1 LOCALSTACK_AUTH_TOKEN=$LOCALSTACK_AUTH_TOKEN lstk start --non-interactive | ||
| # Wait for the LocalStack container to become ready before timing out |
There was a problem hiding this comment.
I think this comment, and the echo following it are a bit misleading. I suggest we only include best practices in our sample application, because that's what humans/agents will copy.
|
|
||
| ## Make sure the LocalStack container is up | ||
| ready: | ||
| @echo Waiting on the LocalStack container... |
There was a problem hiding this comment.
In the samples that I've modified, I generally removed the ready target, since it adds no value with lstk.
| ``` | ||
|
|
||
| We specified `DEBUG=1` to get the printed LocalStack logs directly in the terminal to help us see the event-driven architecture in action. If you prefer running LocalStack in detached mode, you can add the `-d` flag to the `localstack start` command, and use Docker Desktop to view the logs. | ||
| We specified `LOCALSTACK_DEBUG=1` to get the printed LocalStack logs directly in the terminal to help us see the event-driven architecture in action. If you prefer running LocalStack in the background, you can add the `--non-interactive` flag to the `lstk start` command, and use Docker Desktop to view the logs. |
There was a problem hiding this comment.
Not correct, since lstk always run in a detached mode, and not just when --non-interactive is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localstack/awslocal/samlocalinvocations withlstkacross the Makefile, README, and CI workflow.lstk setup awsin CI since the job parseslstk awsoutput.Testing
Part of DEVX-1056