fix: replace ToS-blocked maintain-one-comment action (fixes ephemeral test)#75
Merged
Merged
Conversation
…comment actions-cool/maintain-one-comment was blocked by GitHub for a Terms of Service violation on 2026-05-19. The Actions runner can no longer download it, so every workflow resolving it fails at prep with "Repository access blocked". This broke the ephemeral instance preview flow (the only path using the action) while ci.yml kept passing. Swap all three usages (prepare, finish, ephemeral/shutdown) to the maintained marocchino/sticky-pull-request-comment (SHA-pinned, v3.0.4). The shared `header: localstack-preview` preserves the single-sticky-comment behaviour across the create/update/shutdown lifecycle; marocchino manages its own hidden marker, so the literal HTML marker line is dropped. The "Preview for this PR" text asserted by the ephemeral test is preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The ephemeral instance for the application preview has been shut down |
dominikschubert
approved these changes
Jul 10, 2026
dominikschubert
left a comment
dominikschubert
left a comment
Member
There was a problem hiding this comment.
Thanks for tackling this. I think while it's ok as an immediate fix to unblock #73, I want us to evaluate the usage of an external action here overall before we release a new version of the setup-localstack action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The ephemeral instance test has failed on every PR since ~2026-06-08 with
Repository access blocked, whileci.ymlkeeps passing.The blocked repository is
actions-cool/maintain-one-comment— GitHub blocked it for a Terms of Service violation on 2026-05-19:{ "message": "Repository access blocked", "block": { "reason": "tos", "created_at": "2026-05-19T00:34:15Z" } }The Actions runner downloads actions through the GitHub API, so any step resolving this action dies at job prep (
Getting action download info) before it runs — the exact failure annotation we saw. It's the only blocked action in the dependency tree;jenseng/dynamic-uses,dawidd6/action-download-artifact, and theactions/*ones all resolve fine. (Timeline fits: last green 2026-04-14 → blocked 2026-05-19 → failures from 2026-06-08.) No org allowlist change is involved, and no allowlisting can fix a ToS-blocked repo — it must be replaced.Change
Replace all three usages (
prepare,finish,ephemeral/shutdown) with the maintainedmarocchino/sticky-pull-request-comment(SHA-pinned, v3.0.4):header: localstack-previewpreserves the single sticky-comment behaviour across the create → update → shutdown lifecycle.<!-- Sticky Pull Request Comment -->line is dropped from the message bodies.🚀 Preview for this PR:text asserted byephemeral.ymlis preserved.Verification
This PR triggers
ephemeral.yml— the deploy/shutdown steps should now get pastRepository access blocked, and the "Check PR Comments for preview text" assertion should find the sticky comment.🤖 Generated with Claude Code