deps: fix datascript pin SHA (e439cbac -> e439cba8) - #27
Closed
tiensonqin wants to merge 1 commit into
Closed
tiensonqin wants to merge 1 commit into
tiensonqin wants to merge 1 commit into
Conversation
The e439cbac48b2 SHA was a stale pre-merge object not reachable upstream (GitHub rejects fetch-by-SHA: 'not our ref'), breaking the vendor job. Pin the actual merge commit on main.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #26 pinned datascript to
e439cbac48b2..., which is not reachable onlogseq/datascript-ocaml(GitHub rejects fetch-by-SHA with "not our ref"), so the vendor job fails. The actual merge commit of the Int64 change on main ise439cba85fa0a5b35277959f4737510e3b6a45a7— same tree, correct SHA.Local:
dune build @shared/native/runtestgreen (718 tests).Link to Devin session: https://app.devin.ai/sessions/9a91e201984a4d4f96ce3e0f86ac6668
Open in Devin Desktop: https://app.devin.ai/desktop/session/9a91e201984a4d4f96ce3e0f86ac6668?variant=devin
Requested by: @tiensonqin