composer: build on Lui_element_combine.composer - #30
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Verified the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
view_composer.mlnow delegates the capsule layout toLui_element_combine.composer/composer_collapsedinstead of hand-rolling it. Identical UI/UX: same accessibility identifiers (surface.composer.root,field.composer,row.composer.controls,spacer.composer.*,button.send,button.composer.expand), same per-host variants (Flutter:surface-container-highcapsule + 48ptprimarysend icon +secondarycollapsed "Capture a thought"; Apple: glass capsule + black circulararrow-upsend), same behavior (attachment strip gated by assets signal, autofocus signal,FocusComposercapsule press,SendComposeron send/submit,ExpandComposeron collapsed press).Chat-specific content is passed through the generic params:
~actionscarries the attachment and task-status buttons (with their picker stacks),~attachments/~attachments_visiblecarry the asset strip,~send_iconselectsapp "send"/app "arrow-up"per platform.Bumps the
luipin toe5f940a(the combine-composer branch on logseq/lui, PR #55). Once that PR lands, the pin should move to the merged main sha.Deleted now-duplicated helpers:
with_press,*_composer_send_button,collapsed_composer_button(mli pruned accordingly).Verified:
dune build @shared/native/runtest— 718 tests pass, including the composer layout/parity assertions.Link to Devin session: https://app.devin.ai/sessions/7430d12bacc441448cf27425a36090a4
Open in Devin Desktop: https://app.devin.ai/desktop/session/7430d12bacc441448cf27425a36090a4?variant=devin
Requested by: @tiensonqin