e2e: relaunch emulator when Maestro driver fails to start - #31
Merged
Merged
Conversation
A wedged instrumentation (port never bound, adb channel healthy) took the cheap recover path — force-stop only — so the retry failed in ~4s. Detect AndroidDriverTimeoutException in the captured maestro output and escalate to a full emulator relaunch instead.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main's Android e2e failed with
AndroidDriverTimeoutException— the Maestro instrumentation never bound its port (adbd: failed to connect to socket 'tcp:45705'for 5+ min) while the adb channel stayed healthy.The existing retry took the cheap recovery path —
adb shell echo oksucceeded →recover_deviceonly force-stoppeddev.mobile.maestroand returned in ~4s → the retry hit the same wedged driver instantly.Now the retry loop captures maestro output per attempt; on
AndroidDriverTimeoutException/ "driver did not start" it callsrecover_device force, which skips the connectivity ladder and goes straight to the full emulator relaunch + app reinstall +adb reverserestore path (already written, previously only reached when adb itself was dead).Link to Devin session: https://app.devin.ai/sessions/9a91e201984a4d4f96ce3e0f86ac6668
Open in Devin Desktop: https://app.devin.ai/desktop/session/9a91e201984a4d4f96ce3e0f86ac6668?variant=devin
Requested by: @tiensonqin