Conversation
- decode_picked: tolerate extensionless picks via file_extension fallback\n- stage_copy: stream the temp copy in 64KiB chunks instead of reading the whole file into memory\n- staged_completion: only echo completion for request tokens that already produced a staged pick, so a newly armed picker request isn't prematurely completed\n- clear_graph_surface: drop media_preview so a previous graph's preview can't persist across a graph switch\n- journal_media_view: restore tif/avif to the inline image list (parity with the retired extension)
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address the 5 Devin Review findings on #31 (
e8751e7), applied on top of the merged content ondevin/1790580543-composer-assets.decode_picked:String.sub "" 1 0on extensionless filenames raised and silently discarded the pick → derivefile_typethrough the existingfile_extensionhelper ("bin"fallback) moved above the decoder.stage_copy:really_input_stringread the entire pick into one string → stream copy in 64 KiB chunks; on failure the partial temp file is removed.staged_completion: echoed the armed request token wheneverpending <> [], so a newly armed pick request was completed before its pick could land → trackspent_requests(armed tokens that produced an accepted pick) and only echo completion for those.clear_graph_surface:media_previewsurvived graph switches, leaving the prior graph's QuickLook preview mounted → reset it with the rest of the graph surface.journal_media_view.is_image_type:tif/avifwere dropped versus the retired extension'sisImage(JournalMedia.swift) → restored;file_image's ImageIO thumbnail path decodes both.dune build/dune runtestgreen except the pre-existingV.progressboundary failure (identical on main).Link to Devin session: https://app.devin.ai/sessions/55c3d31f1c6d4ee4beda2f832725d7b7
Open in Devin Desktop: https://app.devin.ai/desktop/session/55c3d31f1c6d4ee4beda2f832725d7b7?variant=devin
Requested by: @RCmerci