Task/various fixes - #483
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Unity SDK authentication, session handling, state persistence, polling, presence, and editor settings.
Changes:
- Adds provider-specific sessions and connected-account APIs.
- Uses realtime waits for polling, presence, and health monitoring.
- Adds profile creation options, integer state persistence, and editor foldouts.
The review identified critical compatibility blockers involving the public state-writer interface, Unity version support, and the remote-session constructor API.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Summary |
|---|---|
Runtime/Game/Resources/LootLockerConfig.cs |
Hides the unset session-mode option; InspectorNameAttribute is incompatible with supported pre-2020.1 Unity versions. |
Runtime/Game/Requests/RemoteSessionRequest.cs |
Adds provider filtering and realtime polling; preserve the existing public constructor for binary compatibility. |
Runtime/Game/Requests/PurchaseRequest.cs |
Uses realtime purchase polling. |
Runtime/Game/Requests/LootLockerSessionRequest.cs |
Adds automatic profile creation control. |
Runtime/Game/Requests/ConnectedAccountRequest.cs |
Adds provider models and connected-account support. |
Runtime/Game/LootLockerSDKManager.cs |
Adds state-writer access and account-linking APIs. |
Runtime/Editor/UpdateChecker/LootLockerUpdateChecker.cs |
Suppresses constant-condition warnings. |
Runtime/Editor/ProjectSettings.cs |
Adds collapsible settings sections; EditorStyles.foldoutHeader is unavailable in Unity 2019.2. |
Runtime/Client/LootLockerStateWriter.cs |
Adds integer persistence methods; changing the public interface breaks existing implementations. |
Runtime/Client/LootLockerStateData.cs |
Exposes the active state writer. |
Runtime/Client/LootLockerPresenceManager.cs |
Uses realtime connection delays. |
Runtime/Client/LootLockerPresenceClient.cs |
Uses realtime presence waits. |
Runtime/Client/LootLockerLifecycleManager.cs |
Uses realtime health-monitor waits. |
Suppressed comments (1)
Runtime/Editor/ProjectSettings.cs:233
- The package declares Unity 2019.2 as its minimum version (
package.json:6), butEditorStyles.foldoutHeaderis not available in that editor version, so this editor script will fail to compile for supported 2019.2 projects. Use a style available on the minimum version (such asEditorStyles.foldout) or guard the newer API with a Unity-version conditional.
presenceSettingsFoldout = EditorGUILayout.Foldout(presenceSettingsFoldout, "Presence Settings", true, EditorStyles.foldoutHeader);
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…onnectGooglePlayGames Adds four new connected account methods and their request types, plus the google_play_games = 11 enum value in LootLockerAccountProvider.
Defaults to true. When false, session start fails with 404 if no profile exists.
…aram Replaces the client-side URL-append hack with a proper providers[] array on the lease request body, matching the backend API contract.
…Writer() Adds integer read/write to the state writer interface with PlayerPrefs and no-op implementations, plus a public accessor on LootLockerSDKManager.
Prevents timing drift when Time.timeScale is modified (e.g., paused games). Affects health checks, presence reconnect/ping, purchase polling, and remote session polling.
…able warnings - Groups log settings and presence settings into collapsible foldouts - Presence sub-settings now always visible (not gated behind enablePresence) - Removes unused ValidateClearLocalPlayerData method - Adds #pragma warning disable 0162 for compile-time constant branches - Adds [InspectorName(null)] on NotSet enum value
kirre-bylund
force-pushed
the
task/various-fixes
branch
from
August 28, 2026 08:12
7b4b18e to
e176d8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.