Repository navigation
fix: prevent communication transfer source-sidecar overwrite - #172
Merged
Merged
Conversation
Owner
Author
2026-10-25 Asia/Shanghai verification receipt
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current defect / 当前缺陷
core/communication_transfer.pyaccepts--outputequal to the input evidence sidecar, overwriting the source after hashing it<output>.tmpstaging path can also collide with an existing source evidence sidecar and destroy itmainon Asia/Shanghai 2026-10-25Proposed repair
tests/test_tool_cli.py, including direct collision and legacy staging collisionEvidence and limitations
.tmpsource, while writing a distinct outputDelivery contract
main; proposed head SHA48378c5b7f85c4d3044b8344a46e59770611b013; prior compareahead=2, behind=0