Repository navigation
DM-56525: Replace the CoaddPSF of the template_detector with a Gaussian - #474
Merged
Merged
Conversation
isullivan
force-pushed
the
tickets/DM-56525
branch
from
October 5, 2026 21:25
f5697a4 to
704e753
Compare
ebellm
approved these changes
Oct 6, 2026
ebellm
left a comment
ebellm
left a comment
Contributor
There was a problem hiding this comment.
Just a small clarification
| dtype=CoaddPsfConfig, | ||
| ) | ||
| fwhmExposureGrid = pexConfig.Field( | ||
| doc="Grid size to compute the average PSF FWHM in an exposure", |
Contributor
There was a problem hiding this comment.
What are the units here? Pixels? Fwhm?
Contributor
Author
There was a problem hiding this comment.
Pixels. I'll add that to this docstring and the other places in ip_diffim with the same wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.