Skip to content

[AppSecAI Agent] Uncontrolled command line #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
conviso-platform-appsec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[AppSecAI Agent] Uncontrolled command line #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 14 additions & 20 deletions advocacia/src/main/java/br/com/advocacia/service/arquivo/ArquivoServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,28 +118,22 @@ public List<Arquivo> findAllModelo() {
@Override
public String lerArquivo(String nome) {
StringBuilder strOut = new StringBuilder();
try{
String[] command;
command = new String[]{"sh", "-c", "cat " + nome};
//command = new String[]{"cmd.exe", "/c", "type " + nome};

Runtime rt = Runtime.getRuntime();
Process proc = rt.exec(command);
int result = proc.waitFor();
if(result != 0){
System.out.println("process error");
}
InputStream in = (result == 0) ? proc.getInputStream():proc.getErrorStream();
int c;
while((c=in.read())!= -1){
strOut.append((char) c);
try {
// Validate and sanitize the file path to prevent command injection
Path filePath = Paths.get(nome).normalize();

// Ensure the path does not contain shell metacharacters or path traversal
String sanitizedPath = filePath.toString();
if (!sanitizedPath.matches("[a-zA-Z0-9_.\\-/\\\\: ]+")) {
throw new SecurityException("Invalid file path: contains disallowed characters.");
}
return strOut.toString();

}catch(Exception e){
return e.toString();
}
// Use Java NIO to read the file instead of executing a shell command
byte[] fileBytes = Files.readAllBytes(filePath);
return new String(fileBytes);

} catch (Exception e) {
return e.toString();
}
}
}

Loading