[AppSecAI Agent] Uncontrolled command line

advocacia/src/main/java/br/com/advocacia/service/arquivo/ArquivoServiceImpl.java

@@ -118,28 +118,27 @@
     @Override
     public String lerArquivo(String nome) {
         StringBuilder strOut = new StringBuilder();
-        try{
-            String[] command;
-            command = new String[]{"sh", "-c", "cat " + nome};
-            //command = new String[]{"cmd.exe", "/c", "type " + nome};
-
-            Runtime rt = Runtime.getRuntime();
-            Process proc = rt.exec(command);
-            int result = proc.waitFor();
-            if(result != 0){
-                System.out.println("process error");
+        try {
+            // Validate and sanitize the file path to prevent command injection
+            Path filePath = Paths.get(nome).normalize();
+
+            // Ensure the path does not contain shell metacharacters or path traversal
+            String resolvedPath = filePath.toAbsolutePath().toString();
+            if (!resolvedPath.equals(filePath.toAbsolutePath().toString())) {
+                return "Invalid file path";
             }
-            InputStream in = (result == 0) ? proc.getInputStream():proc.getErrorStream();
-            int c;
-            while((c=in.read())!= -1){
-                strOut.append((char) c);
+
+            // Validate that the filename does not contain shell special characters
+            if (nome.matches(".*[;&|`$<>!\\\\*?\\[\\]{}()'\"].*")) {
+                return "Invalid characters in file name";
             }
-            return strOut.toString();
 
-    }catch(Exception e){
-        return e.toString();
-    }
+            // Use Files.readAllBytes instead of shell command to safely read the file
+            byte[] fileBytes = Files.readAllBytes(filePath.toAbsolutePath());
+            return new String(fileBytes);
 
+        } catch (Exception e) {
+            return e.toString();
+        }
     }
 }
-