Check the slot's database and plugin before reusing it - #152
Open
lukashes wants to merge 1 commit into
Open
Conversation
Contributor
📊 Benchmark ResultsCurrent run is the minimum over 3 passes, compared against the base branch (
Summary: 🟢 2 faster · ➡️ 8 neutral · ⚪ 3 ignored (sub-μs) Thresholds: <1μs ignore · 1–20μs 15% · 20–50μs 10% · ≥50μs 5%. Measured on a shared CI runner — treat small deltas as noise. Informational only; this check never fails the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slot names are global to the cluster, but
slotExistsmatched on the name alone.A slot of the same name in another database, or one running another output
plugin, passed the check, and
START_REPLICATIONthen failed on every start: arestart loop the supervisor cannot heal.
slotExistsreadsdatabaseandpluginalongsidecurrent_database()andrejects a foreign slot with
SlotMismatch, naming both sides in the log.Returning "no slot" instead would send the run into
createSlot, which failson the name clash and, on the snapshot path, leaves a marker publication behind
on every restart.
the same failure the blocking receive reports, so it propagates instead of
ending the batch as if the buffer had run dry. Nothing is lost: the batch LSN
was never confirmed.
client_timein the standby status update is microseconds since 2000-01-01,not Unix seconds, so
pg_stat_replication.reply_timereads as a realtimestamp.
Closes #97.