Clarify Dispatcher custom executor requirements - #9613
Merged
swankjesse merged 1 commit intoJul 27, 2026
Conversation
Document that a pool sized exactly to maxRequests can reject work when promotion submits from a still-busy worker thread.
swankjesse
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9443
The existing Dispatcher docs say a custom executor only needs to run
maxRequestscalls concurrently. That understates the real requirement: promotion can submit the next call from a worker thread that has not yet returned to the pool, so a pool sized exactly tomaxRequestswith aSynchronousQueuecan reject work.This updates the class KDoc to describe that constraint and point at safe sizing patterns (the default unbounded max pool, roughly
2 * maxRequests, or a queueing executor).Test plan
Dispatcher.ktKDoc for accuracy againstpromoteAndExecute/ default executor