Repository navigation
chore: bump gradle-wrapper from 8.10.2 to 9.8.2 #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/gradle/gradle-wrapper-9.8.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−46
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Every
./gradlewcommand, in CI and locally, will fail at configuration on Gradle 9.8.2. Today on 8.10.2 the same build only warns. build.gradle:13-14 sets top-levelsourceCompatibility/targetCompatibilityon the project. That project-level convention property was deprecated in Gradle 8 and removed in Gradle 9. Fix: move both intojava { sourceCompatibility = JavaVersion.VERSION_1_8; targetCompatibility = JavaVersion.VERSION_1_8 }in build.gradle in this PR, keeping the Java 8 bytecode floor. Also confirm com.vanniktech.maven.publish 0.30.0 works on Gradle 9.Why this was flagged
The trigger is any wrapper invocation after merge, such as
./gradlew buildin push.yml or./gradlew testfor the required Unit Tests check. Line 3 switches distributionUrl to gradle-9.8.2-bin.zip. build.gradle:13sourceCompatibility = JavaVersion.VERSION_1_8and build.gradle:14targetCompatibility = JavaVersion.VERSION_1_8assign project-level properties that came from the Convention API (JavaPluginConvention). Gradle 8.x only logged a deprecation warning for them, and Gradle 9.0 removed them. Groovy DSL then throws "Could not set unknown property 'sourceCompatibility' for root project". On the base branch (8.10.2) the build succeeds. After merge, build, test, and the release-draft/release-publish workflows fail before any task runs, so releases are blocked. Because this Dependabot PR changes only wrapper files, nothing in build.gradle was updated to compensate.Verification: The diff changes gradle-wrapper.properties line 3 to
gradle-9.8.2-bin.zip, while build.gradle lines 13-14 still set top-levelsourceCompatibilityandtargetCompatibility. Gradle 9.0 removed the Convention API they rely on, so every./gradlewrun fails at configuration. On the base (8.10.2) the same lines only log a deprecation warning, so this is a regression this PR introduces.