Add clarifications on awGoToStep constraints#301
Open
theCrius wants to merge 1 commit intomadoar:developfrom
Open
Add clarifications on awGoToStep constraints#301theCrius wants to merge 1 commit intomadoar:developfrom
theCrius wants to merge 1 commit intomadoar:developfrom
Conversation
madoar
reviewed
Jun 13, 2020
Owner
madoar
left a comment
madoar
left a comment
There was a problem hiding this comment.
Thank you for your PR! In the following are some comments I got after looking through the changes
| The `awGoToStep` directive needs to receive an input, which tells the wizard, to which step it should navigate, | ||
| when the element with the `awGoToStep` directive has been clicked. | ||
|
|
||
| > Please be aware that `awGoToStep` will not proceed to another step unless the intermediate steps are marked as optional, using the directive `awOptionalStep`, or has been completed, either by the user or by marking them as completed by default with the directive `awCompletedStep`. |
Owner
There was a problem hiding this comment.
Two suggestions:
- I think we should split this sentence into two to make it easier to understand. It contains multiple subclauses which make it hard to follow the exceptions to the rule
- I'm not sure whether we should use a citation
> ...here. In other places in the README we haven't used citations so I think it is better to continue not using them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.