bugs? - #48
Open
Brandher58 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single owner for revert toasts (no more double error)
RevertDenuvoFix is now the sole emitter of revert feedback (done,
partial, game-not-found, no-manifest), matching the apply path.
ConfirmRevert just flips IsApplied on success. Previously a failed
revert with the game running stacked two error toasts on top of each
other — the exact failure mode you hit most.
Manifest as the apply's commit point (fixes orphaned backups)
ApplyDenuvoFix used to write the manifest at the end inside an empty
catch{} — a busy/locked manifest path silently succeeded, leaving .bak
files with nothing indexing them and no Revert button to ever surface.
Apply now runs in three phases: plan every entry (File.Exists only),
persist the manifest FIRST (abort untouched if it can't be written),
then extract. Any mid-extract failure keeps the manifest on disk, so
the partial result is always recoverable via Revert.