refactor(cache-magento): remove extraneous store input#327
Closed
damienwebdev wants to merge 1 commit intomainfrom
Closed
refactor(cache-magento): remove extraneous store input#327damienwebdev wants to merge 1 commit intomainfrom
damienwebdev wants to merge 1 commit intomainfrom
Conversation
marcelmtz
reviewed
May 3, 2026
marcelmtz
left a comment
marcelmtz
left a comment
There was a problem hiding this comment.
i guess we should also clean this up right https://github.com/mage-os/github-actions/blob/main/.github/workflows/_internal-setup-magento.yaml#L96 ?
Member
Author
|
@marcelmtz I accidentally opened this from this repo as opposed to my fork. Closing and reopening as #348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently,
cache-magentohas an extraneousmodearg that does nothing.Fixes: N/A
What is the new behavior?
This removes the extraneous arg.
Does this PR introduce a breaking change?
Other information