ci: expose nginx port via warden override for e2e access#346
Open
digitalrisedorset wants to merge 1 commit intomage-os:mainfrom
Open
ci: expose nginx port via warden override for e2e access#346digitalrisedorset wants to merge 1 commit intomage-os:mainfrom
digitalrisedorset wants to merge 1 commit intomage-os:mainfrom
Conversation
Member
|
@rhoerr @digitalrisedorset I don't plan to use warden to run tests in CI. I have no familiarity with it and it's seems like far too much overkill for me for what we're trying to accomplish. I'm unassigning myself from review for this as such. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The Warden environment starts successfully in CI, but no HTTP service is exposed to the GitHub Actions runner.
As a result, e2e tests cannot reach the application (no accessible localhost endpoint).
What is the new behavior?
Adds a Warden override (
.warden/warden-env.yml) to expose the web service onlocalhost:8080.This provides a reachable HTTP endpoint for e2e tests in CI.
Does this PR introduce a breaking change?
Other information
This change assumes nginx is the entrypoint exposed by Warden.
If Warden routes traffic via Traefik in CI, exposing Traefik instead may be more appropriate. This PR establishes a baseline to validate HTTP reachability.