Skip to content

feat: add geyser plugin safe-start checks#6

Open
thlorenz wants to merge 70 commits into
masterfrom
validator-safe-start
Open

feat: add geyser plugin safe-start checks#6
thlorenz wants to merge 70 commits into
masterfrom
validator-safe-start

Conversation

@thlorenz
Copy link
Copy Markdown
Collaborator

Summary

Adds safe-start startup checks for the geyser plugin so validator/plugin startup fails early with actionable errors instead of continuing into harder-to-debug runtime failures.

Details

geyser-plugin

  • Adds startup preflight checks during plugin load for validator wrapper config, runtime TOML config, ksqlDB restore setup, Kafka readiness, admin bind availability, and local RPC URL syntax.
  • Improves startup and backfill error messages so failures include the failing component, config field/value context where useful, and a suggested action.
  • Centralizes config validation helpers, including ksql identifier validation and wrapper/runtime config path resolution, so the same checks apply across Makefile and direct validator launch paths.
  • Adjusts ksql restore flow so startup can prefetch restored pubkeys separately from applying them to subscriptions.
  • Makes metrics registration and admin server startup more tolerant of repeated setup paths used by tests/startup validation.
  • Documents the safe-start behavior, manual failure matrix, and success/failure proof commands in the geyser plugin README.

grpc-service

  • Adds startup delay observability so service readiness timing is easier to diagnose when coordinating validator/plugin integration tests.

thlorenz and others added 30 commits April 22, 2026 13:18
* master:
  fix: stabilize geyser plugin startup (#4)
Step 2: Drop the unused allowed field from the ClientCheckpoint struct
and update all four scenario files to stop constructing it:
- ix-tests/src/expectation.rs: Removed allowed field from struct
- ix-tests/src/scenarios/single_basic.rs: Updated lamport_client_checkpoint helper and owner_data_checkpoint block
- ix-tests/src/scenarios/dual_concurrent.rs: Updated single_update_checkpoint helper
- ix-tests/src/scenarios/dual_restart.rs: Updated repeated_checkpoint and empty_checkpoints helpers
- ix-tests/src/scenarios/single_load.rs: Removed allowed from construction

All ix-tests unit tests pass. Clippy errors in expectation.rs were auto-fixed (collapsible_if).

Amp-Thread-ID: https://ampcode.com/threads/T-019dd298-cc3a-716f-a374-2375f3a99bf0
Co-authored-by: Amp <amp@ampcode.com>
The checkpoint runner re-evaluated every required entry against the
full observation snapshot on each loop iteration. Required entries
that had already been satisfied were re-checked against the same
observations every tick, and a single observation could be counted
toward multiple distinct required entries.

Track per-client matching state across loop iterations so that:
- each required entry, once matched, stays matched and is not
  re-evaluated;
- each loop iteration only scans observations that arrived since the
  last poll;
- each observation can only consume a single required entry.

Replace the previous unmatched_required helper with a stateful
consume_observations helper and update unit tests to cover the new
incremental, consuming behavior.

Amp-Thread-ID: https://ampcode.com/threads/T-019dd29f-8b80-76bf-8a1f-623f120781d8
Co-authored-by: Amp <amp@ampcode.com>
thlorenz and others added 27 commits May 3, 2026 16:58
* master:
  feat: add ix integration test suite (#5)
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Warning

Rate limit exceeded

@thlorenz has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 34 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3eff92e4-a78a-4d4a-b275-533687d8f33c

📥 Commits

Reviewing files that changed from the base of the PR and between d877d28 and dbf0709.

📒 Files selected for processing (13)
  • geyser-plugin/README.md
  • geyser-plugin/src/config.rs
  • geyser-plugin/src/initial_account_backfill/mod.rs
  • geyser-plugin/src/initial_account_backfill/rpc.rs
  • geyser-plugin/src/ksql.rs
  • geyser-plugin/src/lib.rs
  • geyser-plugin/src/metrics.rs
  • geyser-plugin/src/plugin/mod.rs
  • geyser-plugin/src/preflight.rs
  • geyser-plugin/src/server/accounts.rs
  • geyser-plugin/src/server/mod.rs
  • geyser-plugin/src/server/prom.rs
  • grpc-service/src/app.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch validator-safe-start

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thlorenz
Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant