perf: replace repeated string.Contains with single-pass field parsing - #90
Open
g4dpz wants to merge 1 commit into
Open
perf: replace repeated string.Contains with single-pass field parsing#90g4dpz wants to merge 1 commit into
g4dpz wants to merge 1 commit into
Conversation
Owner
|
Thanks for this — looks sensible, but it currently conflicts with Please rebase or merge |
ApplyStatusUnlocked previously called HasSliceField (string.Contains with interpolated string) up to 8 times per status message, causing 8 string allocations + 8 full scans per radio update (~4 Hz). Replace with ParsePresentFields: a single-pass tokeniser that builds a HashSet<string> of field names present in the status body, then all 7 field checks become O(1) lookups with zero per-field allocations. Note: upstream has added PanStreamId/pan handling since this branch was cut. The ParsePresentFields approach can also replace HasPanField for the pan status messages — happy to add that in a follow-up once this merges. Includes 6 unit tests covering typical status, FM tone fields, case-insensitive lookup, tokens without equals, empty body, and extra whitespace.
g4dpz
force-pushed
the
optimise/flex-status-field-parsing
branch
from
August 3, 2026 08:07
95361ec to
e74a5d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApplyStatusUnlockedpreviously calledHasSliceField(which usesstring.Containswith an interpolated string) up to 8 times per status message. This caused 8 string allocations + 8 full-string scans per radio update (~4 Hz during satellite tracking).Changes
Replaced with
ParsePresentFields: a single-pass tokeniser that builds aHashSet<string>of field names present in the status body, then all 7 field checks become O(1) lookups with zero per-field allocations.Tests
6 unit tests added covering:
All 55 Flex tests pass.