perf: use dictionary index for community status satellite lookups - #97
Merged
magicbug merged 1 commit intoAug 7, 2026
Merged
Conversation
TryGetMode and TryGetSatellite previously iterated the Satellites list linearly on every call (O(n)). These are called from the UI rendering path for each enabled satellite's status indicator. Build a lazily-initialized Dictionary<string, ...> keyed by name (case-insensitive) on first access. Subsequent lookups are O(1). The index is built once per API fetch (every 5 minutes) and reused for all rendering ticks in between.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TryGetModeandTryGetSatelliteonSatelliteCommunityCatalogpreviously iterated theSatelliteslist linearly on every call (O(n)). These are called from the UI rendering path for each enabled satellite's status indicator (~10 lookups per tick at 4 Hz = ~40 linear scans/second).Changes
Build a lazily-initialized
Dictionary<string, SatelliteCommunitySatelliteStatus>keyed by satellite name (case-insensitive) on first access. Subsequent lookups are O(1). The index is built once per API fetch (every 5 minutes) and reused for all rendering ticks in between.TryGetSatellite→ singleDictionary.GetValueOrDefaultcallTryGetMode→ dictionary lookup for satellite, then short linear scan of modes (typically 1-3 modes per satellite)Tests
All 42 existing SatelliteStatus tests pass unchanged.