v3.5.0 with api barrel#51
Conversation
|
Warning Review limit reached
More reviews will be available in 48 minutes and 24 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughBumps package versions to 3.5.0, adds a new Changesv3.5.0 Release
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/tempo/doc/installation.md (2)
164-191: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winDocument the new
./plugin-apisubpath export in the granular ESM section.The new
plugin-apibarrel (introduced in this release) explicitly simplifies static CDN importmaps by consolidating core, library, plugin, support, and term APIs into a single importable path. Given that this section describes the complex granular importmap required for static CDNs, it should mention that@magmacomputing/tempo/plugin-apiis available as a simpler alternative. Add an entry like:"`@magmacomputing/tempo/plugin-api`": "https://cdn.jsdelivr.net/npm/@magmacomputing/tempo@3/dist/plugin-api.index.js"and explain when to use it versus the full granular map.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/tempo/doc/installation.md` around lines 164 - 191, The Granular ESM documentation is missing the new `@magmacomputing/tempo/plugin-api` subpath export, which should be presented as the simpler static-CDN option. Update the installation.md “Granular ESM (Advanced Plugin Architecture)” section to add the plugin-api importmap entry alongside the existing core/library/plugin mappings, and clarify that plugin-api can replace the full granular map when consumers want a single barrel for core, library, plugin, support, and term APIs. Use the existing importmap example in this section and the `@magmacomputing/tempo/plugin-api` symbol to place the change.
177-177: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winUpdate version pins in granular ESM importmap to match current release.
The granular ESM example still references
@3.2.1(line 177) and@3.2.0(lines 178-184) but this release bumps to 3.5.0. These stale version pins will mislead users and may cause compatibility issues with the newplugin-apisubpath. Update to@3or@3.5.1for consistency with the release.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/tempo/doc/installation.md` at line 177, The granular ESM importmap in the installation docs still has stale Tempo version pins that don’t match the current release. Update the imports in the importmap example to use the new 3.5.x-compatible versioning (or a major pin like `@3`) across all referenced entries, including the main tempo import and the plugin-api subpath, so the example stays consistent with the release and avoids misleading users.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/tempo/doc/installation.md`:
- Line 9: The installation doc currently overstates native Temporal support by
claiming Node.js 26+; update the wording in the installation section to reflect
the correct Node.js minimum for unflagged native Temporal support and avoid
implying a non-existent release. Check the surrounding Temporal support
statement in the doc text, verify the current Node.js version claim, and revise
the sentence so it distinguishes between flagged support and true native
availability.
---
Outside diff comments:
In `@packages/tempo/doc/installation.md`:
- Around line 164-191: The Granular ESM documentation is missing the new
`@magmacomputing/tempo/plugin-api` subpath export, which should be presented as
the simpler static-CDN option. Update the installation.md “Granular ESM
(Advanced Plugin Architecture)” section to add the plugin-api importmap entry
alongside the existing core/library/plugin mappings, and clarify that plugin-api
can replace the full granular map when consumers want a single barrel for core,
library, plugin, support, and term APIs. Use the existing importmap example in
this section and the `@magmacomputing/tempo/plugin-api` symbol to place the
change.
- Line 177: The granular ESM importmap in the installation docs still has stale
Tempo version pins that don’t match the current release. Update the imports in
the importmap example to use the new 3.5.x-compatible versioning (or a major pin
like `@3`) across all referenced entries, including the main tempo import and the
plugin-api subpath, so the example stays consistent with the release and avoids
misleading users.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 433f93d3-bb5f-418a-959f-45f2cfe59ca7
📒 Files selected for processing (8)
package.jsonpackages/library/package.jsonpackages/tempo/README.mdpackages/tempo/doc/installation.mdpackages/tempo/doc/tempo.cookbook.mdpackages/tempo/package.jsonpackages/tempo/src/plugin-api.index.tspackages/tempo/src/tempo.version.ts
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/tempo/doc/installation.md (1)
46-46: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winRemove incorrect Node.js 26 version claim.
Line 46 states "Node.js 26.0.0 or later" as if this version exists. This should be reworded to avoid specifying a non-existent version, consistent with the correction needed at lines 9-14.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/tempo/doc/installation.md` at line 46, The installation docs in the Temporal section should not claim support for a non-existent Node.js 26.0.0 release; update the sentence to use a valid, non-specific future/current wording instead. Reword the affected text in the documentation so it stays consistent with the earlier Node.js version guidance and does not mention a specific nonexistent version.
🧹 Nitpick comments (1)
packages/tempo/template/index.sample.html (1)
19-19: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winPin the
@js-temporal/polyfillCDN URL to an exact release.@0follows the latest 0.x publish, so this template can change behavior without any repo update.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/tempo/template/index.sample.html` at line 19, The template is using a floating CDN reference for `@js-temporal/polyfill`, which can change behavior without a repo update. Update the import map entry in the sample HTML template to point to a specific released version instead of `@0`, keeping the existing `@js-temporal/polyfill` symbol and only changing the CDN URL to an exact pinned release.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/tempo/doc/installation.md`:
- Around line 9-14: The installation guidance in `Tempo` still makes a
speculative claim about native unflagged `Temporal` support in Node.js 26, so
update the text in the documentation snippet to use accurate non-committal
wording like “a future Node.js release” or remove the version number entirely.
Keep the rest of the `Temporal` support explanation and the
`@js-temporal/polyfill` warning intact, and ensure the revised wording matches
the current `Temporal` support status without naming an unreleased Node.js
version.
---
Outside diff comments:
In `@packages/tempo/doc/installation.md`:
- Line 46: The installation docs in the Temporal section should not claim
support for a non-existent Node.js 26.0.0 release; update the sentence to use a
valid, non-specific future/current wording instead. Reword the affected text in
the documentation so it stays consistent with the earlier Node.js version
guidance and does not mention a specific nonexistent version.
---
Nitpick comments:
In `@packages/tempo/template/index.sample.html`:
- Line 19: The template is using a floating CDN reference for
`@js-temporal/polyfill`, which can change behavior without a repo update. Update
the import map entry in the sample HTML template to point to a specific released
version instead of `@0`, keeping the existing `@js-temporal/polyfill` symbol and
only changing the CDN URL to an exact pinned release.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d2dd3155-408a-4dbf-9dab-9d5e662d5fd9
📒 Files selected for processing (7)
bin/version-bump.mjsbin/version-sync.mjspackage.jsonpackages/tempo/doc/installation.mdpackages/tempo/doc/tempo.plugin.mdpackages/tempo/doc/tempo.term.mdpackages/tempo/template/index.sample.html
✅ Files skipped from review due to trivial changes (3)
- bin/version-sync.mjs
- packages/tempo/doc/tempo.term.md
- packages/tempo/doc/tempo.plugin.md
1 participant
Summary by CodeRabbit
New Features
plugin-apientry point for Tempo’s plugin capabilities.Documentation
Chores