Release 1.1.0 - #7
Conversation
Bump the version, cut the Unreleased changelog into the 1.1.0 section, and ship CHANGELOG.md in the npm tarball so consumers see the breaking credential-binding notice.
WalkthroughUpdates the package from beta to stable version 1.1.0, includes ChangesStable release metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)package.jsonTraceback (most recent call last): 🔧 ESLint
package.jsonParsing error: ESLint was configured to run on Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
15-16: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAssert that
CHANGELOG.mdis included in the packed tarball.The package metadata adds the file, but
tests/acceptance/lib/pack.tsonly requires the manifest, binary, dist, and completions. AddentrySet.has('package/CHANGELOG.md')so this release requirement is protected against regression.Proposed test update
const requiredFilesPresent = entrySet.has('package/bin/run.js') && entrySet.has('package/oclif.manifest.json') && + entrySet.has('package/CHANGELOG.md') && entries.some(entry => entry.startsWith('package/dist/')) &&🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 15 - 16, Update the tarball acceptance assertions in the pack test’s entry-set validation to require entrySet.has('package/CHANGELOG.md'), alongside the existing manifest, binary, dist, and completions checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package.json`:
- Around line 15-16: Update the tarball acceptance assertions in the pack test’s
entry-set validation to require entrySet.has('package/CHANGELOG.md'), alongside
the existing manifest, binary, dist, and completions checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bd64d2c7-f78e-4366-ae5e-fc78a14cc16c
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
CHANGELOG.mdpackage.json
Version bump to 1.1.0, changelog cut for the release, and one packaging change: CHANGELOG.md now ships in the npm tarball so consumers see the breaking credential-binding notice.
The 1.1.0 section leads with the breaking change: keychain credentials are bound to the profile's canonical Dashboard identity, and each profile stored by an earlier version needs a one-time
mainwpcontrol login.No source changes; CI plus the changelog diff is the review surface.
Summary by CodeRabbit
Documentation
Chores